Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18542: Fixed topology package e2e tests #13136

Merged
merged 1 commit into from Dec 2, 2023
Merged

OCPBUGS-18542: Fixed topology package e2e tests #13136

merged 1 commit into from Dec 2, 2023

Conversation

sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Sep 5, 2023 •
edited

Issue: https://issues.redhat.com/browse/OCPBUGS-18542
Description: Fixed tests in the topology package

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/topology Related to topology approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2023
@sanketpathak sanketpathak changed the title Fixed topology package e2e tests OCPBUGS-18542: Fixed topology package e2e tests Sep 5, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 5, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-18542, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-18542
Description: Fixed tests in the topology package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@sanketpathak
Copy link
Contributor Author

/retest

@sanketpathak sanketpathak force-pushed the topology-regression-fixation branch 5 times, most recently from 9c4b202 to c3b7377 Compare September 10, 2023 12:13
@vikram-raj
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 11, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-18542, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@vikram-raj: This pull request references Jira Issue OCPBUGS-18542, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/retest

@vikram-raj
Copy link
Member

/retest

1 similar comment
@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/uncc christianvogt divyanshiGupta
/cc @The-Anton

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@The-Anton
Copy link
Member

All test are passing.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b5d67e3 and 2 for PR HEAD 54aa956 in total

@sanketpathak
Copy link
Contributor Author

It only updates the integration tests

/label acknowledge-critical-fixes-only
/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-18542, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-18542
Description: Fixed tests in the topology package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sanketpathak: This pull request references Jira Issue OCPBUGS-18542, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-18542
Description: Fixed tests in the topology package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@The-Anton
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanketpathak, The-Anton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 70a927c and 2 for PR HEAD b0d7bea in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2155d74 and 1 for PR HEAD b0d7bea in total

@sanketpathak
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e762b55 and 0 for PR HEAD b0d7bea in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1e82cbd into openshift:master Dec 2, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: Jira Issue OCPBUGS-18542: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18542 has been moved to the MODIFIED state.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-18542
Description: Fixed tests in the topology package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202312020449.p0.g1e82cbd.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

@sanketpathak
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@sanketpathak: new pull request created: #13523

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Anton The-Anton Awaiting requested review from The-Anton

Assignees

@The-Anton The-Anton

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sanketpathak @openshift-ci-robot @vikram-raj @jerolimov @The-Anton @openshift-bot @openshift-merge-robot @openshift-cherrypick-robot