OCPBUGS-19743: Fix Invalid URL crash

[jerolimov]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19743

Analysis / Root cause:
After #13102 got merged, it wasn't possible to start the local console bridge anymore.

The UI crashes with this error:

Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at ./public/module/auth.js (main-c115e44b78283c32bc69.js:81514:7)
    at __webpack_require__ (runtime~main-bundle.js:90:30)

The loginErrorURL is a string that couldn't get parsed with new URL:

window.SERVER_FLAGS.loginErrorURL
'/auth/error'

new URL(window.SERVER_FLAGS.loginErrorURL)
VM55:1 Uncaught TypeError: Failed to construct 'URL': Invalid URL

Solution Description:

1. Added the current URL as base URL as second parameter to the URL constructor.
2. Updated isLoginErrorPath because LOGIN_ERROR_PATH is a string, no an URL object.

To be honest, I didn't retested #13102 yet.

Test setup:

1. Start a local console with ./bin/bridge

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-19743, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jerolimov: This pull request references Jira Issue OCPBUGS-19743, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19743

Analysis / Root cause:
After #13102 got merged, it wasn't possible to start the local console bridge anymore.

The UI crashes with this error:

Uncaught TypeError: Failed to construct 'URL': Invalid URL
   at ./public/module/auth.js (main-c115e44b78283c32bc69.js:81514:7)
   at __webpack_require__ (runtime~main-bundle.js:90:30)

The loginErrorURL is a string that couldn't get parsed with new URL:

window.SERVER_FLAGS.loginErrorURL
'/auth/error'

new URL(window.SERVER_FLAGS.loginErrorURL)
VM55:1 Uncaught TypeError: Failed to construct 'URL': Invalid URL

Solution Description:

1. Added the current URL as base URL as second parameter to the URL constructor.
2. Updated isLoginErrorPath because LOGIN_ERROR_PATH is a string, no an URL object.

To be honest, I didn't retested #13102 yet.

Test setup:

1. Start a local console with ./bin/bridge

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/cc @vikram-raj @TheRealJon @jhadvig @spadgett
/uncc kyoto rhamilto

[vikram-raj]

Verified it locally, not seeing any error and it works as expected.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jerolimov,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jerolimov: Jira Issue OCPBUGS-19743: All pull requests linked via external trackers have merged:

• openshift/console#13192

Jira Issue OCPBUGS-19743 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19743

Analysis / Root cause:
After #13102 got merged, it wasn't possible to start the local console bridge anymore.

The UI crashes with this error:

Uncaught TypeError: Failed to construct 'URL': Invalid URL
   at ./public/module/auth.js (main-c115e44b78283c32bc69.js:81514:7)
   at __webpack_require__ (runtime~main-bundle.js:90:30)

The loginErrorURL is a string that couldn't get parsed with new URL:

window.SERVER_FLAGS.loginErrorURL
'/auth/error'

new URL(window.SERVER_FLAGS.loginErrorURL)
VM55:1 Uncaught TypeError: Failed to construct 'URL': Invalid URL

Solution Description:

1. Added the current URL as base URL as second parameter to the URL constructor.
2. Updated isLoginErrorPath because LOGIN_ERROR_PATH is a string, no an URL object.

To be honest, I didn't retested #13102 yet.

Test setup:

1. Start a local console with ./bin/bridge

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353