Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19783: Channel page shows "Required" message for the default name when navigate to create channel page #13222

Merged

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19783

Analysis / Root cause:
Form was not re-validated after updating form name

Solution Description:
Added ValidateForm inside setTimeout method

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2023-10-09.at.11.06.37.AM.mov

----AFTER----

Screen.Recording.2023-10-09.at.11.07.10.AM.mov

Unit test coverage report:
NA

Test setup:

  1. Install serverless operator
  2. Go to Add page in developer perspective
  3. Click on the channel card

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2023
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-19783, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19783

Analysis / Root cause:
Form was not re-validated after updating form name

Solution Description:
Added ValidateForm inside setTimeout method

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2023-10-09.at.11.06.37.AM.mov

----AFTER----

Screen.Recording.2023-10-09.at.11.07.10.AM.mov

Unit test coverage report:
NA

Test setup:

  1. Install serverless operator
  2. Go to Add page in developer perspective
  3. Click on the channel card

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 9, 2023
@openshift-ci openshift-ci bot added the component/knative Related to knative-plugin label Oct 9, 2023
@lokanandaprabhu
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2023
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-19783, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19783

Analysis / Root cause:
Form was not re-validated after updating form name

Solution Description:
Added ValidateForm inside setTimeout method

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2023-10-09.at.11.06.37.AM.mov

----AFTER----

Screen.Recording.2023-10-09.at.11.07.10.AM.mov

Unit test coverage report:
NA

Test setup:

  1. Install serverless operator
  2. Go to Add page in developer perspective
  3. Click on the channel card

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-19783, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-19783, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19783

Analysis / Root cause:
Form was not re-validated after updating form name

Solution Description:
Added ValidateForm inside setTimeout method

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2023-10-09.at.11.06.37.AM.mov

----AFTER----

Screen.Recording.2023-10-09.at.11.07.10.AM.mov

Unit test coverage report:
NA

Test setup:

  1. Install serverless operator
  2. Go to Add page in developer perspective
  3. Click on the channel card

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lokanandaprabhu
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@openshift-ci openshift-ci bot merged commit 689196f into openshift:master Oct 19, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-19783: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19783 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-19783

Analysis / Root cause:
Form was not re-validated after updating form name

Solution Description:
Added ValidateForm inside setTimeout method

Screen shots / Gifs for design review:
----BEFORE---

Screen.Recording.2023-10-09.at.11.06.37.AM.mov

----AFTER----

Screen.Recording.2023-10-09.at.11.07.10.AM.mov

Unit test coverage report:
NA

Test setup:

  1. Install serverless operator
  2. Go to Add page in developer perspective
  3. Click on the channel card

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lokanandaprabhu
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@lokanandaprabhu: new pull request created: #13262

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants