Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20362: Delete results.tekton.dev annotations before rerun the pipelineRun #13230

Merged
merged 1 commit into from Oct 20, 2023
Merged

OCPBUGS-20362: Delete results.tekton.dev annotations before rerun the pipelineRun #13230

merged 1 commit into from Oct 20, 2023

Conversation

vikram-raj
Copy link
Member

Fixes: https://issues.redhat.com/browse/OCPBUGS-20362

Descriptions: Creating a PipelineRun with previous annotations leads to the result not being created. But records are updated with new TaskRuns. This PR deletes the results.tekton.dev annotations from the previous PipelineRun.

GIF:

ocpbugs-20362.mov

@vikram-raj vikram-raj changed the title Delete results.tekton.dev annotations before rerun the pipelineRun OCPBUGS-20362: Delete results.tekton.dev annotations before rerun the pipelineRun Oct 11, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 11, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-20362, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-20362

Descriptions: Creating a PipelineRun with previous annotations leads to the result not being created. But records are updated with new TaskRuns. This PR deletes the results.tekton.dev annotations from the previous PipelineRun.

GIF:

ocpbugs-20362.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2023
@vikram-raj
Copy link
Member Author

/cc @lokanandaprabhu

jerolimov
jerolimov approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f9662a7 and 2 for PR HEAD 1b5acdc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 689196f and 1 for PR HEAD 1b5acdc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f9117c8 and 0 for PR HEAD 1b5acdc in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 1b5acdc was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@vikram-raj
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@vikram-raj
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 0fe2319 into openshift:master Oct 20, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-20362: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20362 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-20362

Descriptions: Creating a PipelineRun with previous annotations leads to the result not being created. But records are updated with new TaskRuns. This PR deletes the results.tekton.dev annotations from the previous PipelineRun.

GIF:

ocpbugs-20362.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the ocpbugs-20362 branch October 20, 2023 17:13
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302

@vikram-raj
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@vikram-raj: new pull request created: #13278

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@rottencandy rottencandy Awaiting requested review from rottencandy

@sahil143 sahil143 Awaiting requested review from sahil143

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vikram-raj @openshift-ci-robot @openshift-merge-robot @openshift-cherrypick-robot @jerolimov