Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7400: Fix e2e for dev-console, knative, topology, helm and pipeline packages #13231

Merged
merged 4 commits into from Oct 14, 2023
Merged

ODC-7400: Fix e2e for dev-console, knative, topology, helm and pipeline packages #13231

merged 4 commits into from Oct 14, 2023

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Oct 11, 2023 •
edited

Story: ODC-7400

Descriptions: Enable and fix e2e tests post cypress upgrade

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/topology Related to topology kind/cypress Related to Cypress e2e integration testing labels Oct 11, 2023
@vikram-raj
Copy link
Member Author

/cc @sanketpathak

@vikram-raj
Copy link
Member Author

/retest

@vikram-raj vikram-raj changed the title Fix e2e for dev-console, knative, topology, helm and pipeline packages ODC-7400: Fix e2e for dev-console, knative, topology, helm and pipeline packages Oct 12, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 12, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR have commits from PR #13070

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link
Contributor

@vikram-raj Please add this topologyPage.verifyWorkloadInTopologyPage(helmReleaseName); before this line the failed tests will work

@vikram-raj
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Story: ODC-7400

Descriptions: Enable and fix e2e tests post cypress upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto
rhamilto approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit regarding removing commented code. Otherwise LGTM

frontend/packages/dev-console/integration-tests/plugins/index.js Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
rhamilto
rhamilto approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@vikram-raj
Copy link
Member Author

No doc and UX changes

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 13, 2023
@vikram-raj
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2023

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sanketpathak
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2023 •
edited by openshift-ci bot

@vikram-raj: This pull request references ODC-7400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Story: ODC-7400

Descriptions: Enable and fix e2e tests post cypress upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 994489c into openshift:master Oct 14, 2023
6 checks passed
@vikram-raj vikram-raj deleted the fix-e2e-odc branch October 14, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@jerolimov jerolimov Awaiting requested review from jerolimov

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vikram-raj @openshift-ci-robot @sanketpathak @rhamilto