OCPBUGS-30077: Add additional search filters in the toolbar #13233

upalatucci · 2023-10-12T07:44:56Z

Hi guys this is the PR to add search filters to the ListPageFilter component.

I've added a new RowSearchFilter type to the rowFilters prop. The new type has a placeholder key and does not have the key items as in the search params there are no options but the user needs actually to type. It's not shown in the Filter popup but in the dropdown.
For other things is treated as a normal RowFilter.

Another option would be to have a different prop for that kind of filter.

I have shared some screenshots with an example with pod list.

With Name and Labels

With no name and no labels

upalatucci · 2023-10-12T12:20:50Z

/retest

upalatucci · 2023-10-13T07:28:18Z

/retest

spadgett · 2023-10-13T13:12:41Z

@jhadvig Can you help find a reviewer for the PR?

@upalatucci Let's make sure well documented the new feature in our API docs.

frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts

...binding-plugin/src/components/service-binding-list/__tests__/ServiceBindingListPage.spec.tsx

frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts

vojtechszocs · 2023-12-11T15:50:19Z

frontend/public/components/filter-toolbar.tsx

+      }}
+      chips={searchFiltersState[searchFilter.type] ? [searchFiltersState[searchFilter.type]] : []}
+    >
+      <></>


Nit: why do we need an empty React fragment here?

ToolbarFilter component wants a child. Without anything, it raises errors.

frontend/public/components/useSearchFilters.ts

upalatucci · 2024-01-17T10:14:24Z

/retest

upalatucci · 2024-01-18T08:55:48Z

/retest

upalatucci · 2024-01-19T13:28:49Z

/retest

upalatucci · 2024-01-24T14:34:18Z

/retest

frontend/packages/console-dynamic-plugin-sdk/src/api/dynamic-core-api.ts

frontend/public/components/filter-toolbar.tsx

openshift-ci-robot · 2024-02-07T09:34:17Z

@upalatucci: This pull request references CONSOLE-3936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

@spadgett @vojtechszocs

Hi guys this is the PR to add search filters to the ListPageFilter component.

I've added a new RowSearchFilter type to the rowFilters prop. The new type has a placeholder key and does not have the key items as in the search params there are no options but the user needs actually to type. It's not shown in the Filter popup but in the dropdown.
For other things is treated as a normal RowFilter.

Another option would be to have a different prop for that kind of filter.

I have shared some screenshots with an example with pod list.

With Name and Labels

With no name and no labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2024-02-07T09:34:19Z

/retest

upalatucci · 2024-02-08T09:37:54Z

/retest

upalatucci · 2024-02-09T14:30:03Z

/retest

upalatucci · 2024-02-12T15:56:39Z

/retest

upalatucci · 2024-02-13T13:20:20Z

/retest

upalatucci · 2024-02-15T09:12:07Z

/retest

upalatucci · 2024-02-20T13:00:35Z

/retest

upalatucci · 2024-02-21T10:48:48Z

/retest

upalatucci · 2024-02-22T09:35:20Z

/retest

vojtechszocs · 2024-02-28T17:52:10Z

/lgtm

openshift-ci · 2024-02-28T17:52:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

upalatucci · 2024-02-29T08:24:58Z

/jira refresh

openshift-ci-robot · 2024-02-29T08:25:02Z

@upalatucci: This pull request references CONSOLE-3936 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-29T08:30:13Z

@upalatucci: This pull request references CONSOLE-3963 which is a valid jira issue.

In response to this:

@spadgett @vojtechszocs

Hi guys this is the PR to add search filters to the ListPageFilter component.

I've added a new RowSearchFilter type to the rowFilters prop. The new type has a placeholder key and does not have the key items as in the search params there are no options but the user needs actually to type. It's not shown in the Filter popup but in the dropdown.
For other things is treated as a normal RowFilter.

Another option would be to have a different prop for that kind of filter.

I have shared some screenshots with an example with pod list.

With Name and Labels

With no name and no labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2024-02-29T08:30:16Z

/jira refresh

openshift-ci-robot · 2024-02-29T08:30:18Z

@upalatucci: This pull request references CONSOLE-3963 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

upalatucci · 2024-02-29T09:05:13Z

/jira refresh

openshift-ci-robot · 2024-02-29T09:05:18Z

@upalatucci: This pull request references Jira Issue OCPBUGS-30077, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@spadgett @vojtechszocs

Hi guys this is the PR to add search filters to the ListPageFilter component.

I've added a new RowSearchFilter type to the rowFilters prop. The new type has a placeholder key and does not have the key items as in the search params there are no options but the user needs actually to type. It's not shown in the Filter popup but in the dropdown.
For other things is treated as a normal RowFilter.

Another option would be to have a different prop for that kind of filter.

I have shared some screenshots with an example with pod list.

With Name and Labels

With no name and no labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-29T09:05:20Z

@upalatucci: This pull request references Jira Issue OCPBUGS-30077, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-29T15:26:35Z

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-02-29T15:32:39Z

@upalatucci: Jira Issue OCPBUGS-30077: All pull requests linked via external trackers have merged:

openshift/console#13233

Jira Issue OCPBUGS-30077 has been moved to the MODIFIED state.

In response to this:

@spadgett @vojtechszocs

Hi guys this is the PR to add search filters to the ListPageFilter component.

I've added a new RowSearchFilter type to the rowFilters prop. The new type has a placeholder key and does not have the key items as in the search params there are no options but the user needs actually to type. It's not shown in the Filter popup but in the dropdown.
For other things is treated as a normal RowFilter.

Another option would be to have a different prop for that kind of filter.

I have shared some screenshots with an example with pod list.

With Name and Labels

With no name and no labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-02-29T19:56:11Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202402291846.p0.g2d3c1cb.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

openshift-merge-robot · 2024-03-05T16:40:47Z

Fix included in accepted release 4.16.0-0.nightly-2024-03-05-105513

openshift-ci bot requested review from jerolimov and spadgett October 12, 2023 07:47

openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk labels Oct 12, 2023

vojtechszocs reviewed Oct 16, 2023

View reviewed changes

frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts Outdated Show resolved Hide resolved

frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts Outdated Show resolved Hide resolved

upalatucci force-pushed the filter-toolbar-additional-search branch 2 times, most recently from d0bacdb to e2863d1 Compare December 11, 2023 15:19

vojtechszocs suggested changes Dec 11, 2023

View reviewed changes

upalatucci force-pushed the filter-toolbar-additional-search branch 3 times, most recently from 3e9eeaf to 31d1252 Compare January 12, 2024 15:38

vojtechszocs reviewed Feb 5, 2024

View reviewed changes

upalatucci force-pushed the filter-toolbar-additional-search branch from 31d1252 to c06171b Compare February 5, 2024 17:59

upalatucci changed the title ~~Add additional search filters in the toolbar~~ CONSOLE-3936: Add additional search filters in the toolbar Feb 7, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2024

upalatucci force-pushed the filter-toolbar-additional-search branch 3 times, most recently from 1742148 to b2747a2 Compare February 7, 2024 13:28

jhadvig assigned vojtechszocs Feb 8, 2024

upalatucci requested a review from vojtechszocs February 26, 2024 16:24

Add additional search filters in the toolbar

fb8052e

upalatucci force-pushed the filter-toolbar-additional-search branch from b2747a2 to fb8052e Compare February 28, 2024 17:48

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024

upalatucci changed the title ~~CONSOLE-3936: Add additional search filters in the toolbar~~ CONSOLE-3963: Add additional search filters in the toolbar Feb 29, 2024

upalatucci changed the title ~~CONSOLE-3963: Add additional search filters in the toolbar~~ OCPBUGS-30077: Add additional search filters in the toolbar Feb 29, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 29, 2024

openshift-ci bot requested a review from yapei February 29, 2024 09:05

openshift-merge-bot bot merged commit 2d3c1cb into openshift:master Feb 29, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-30077: Add additional search filters in the toolbar #13233

OCPBUGS-30077: Add additional search filters in the toolbar #13233

upalatucci commented Oct 12, 2023 •

edited

upalatucci commented Oct 12, 2023

upalatucci commented Oct 13, 2023

spadgett commented Oct 13, 2023

vojtechszocs Dec 11, 2023

upalatucci Jan 12, 2024

upalatucci commented Jan 17, 2024

upalatucci commented Jan 18, 2024

upalatucci commented Jan 19, 2024

upalatucci commented Jan 24, 2024

openshift-ci-robot commented Feb 7, 2024 •

edited by openshift-ci bot

upalatucci commented Feb 7, 2024

upalatucci commented Feb 8, 2024

upalatucci commented Feb 9, 2024

upalatucci commented Feb 12, 2024

upalatucci commented Feb 13, 2024

upalatucci commented Feb 15, 2024

upalatucci commented Feb 20, 2024

upalatucci commented Feb 21, 2024

upalatucci commented Feb 22, 2024

vojtechszocs commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

upalatucci commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

upalatucci commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

upalatucci commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024

openshift-ci bot commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024

openshift-bot commented Feb 29, 2024

openshift-merge-robot commented Mar 5, 2024

OCPBUGS-30077: Add additional search filters in the toolbar #13233

OCPBUGS-30077: Add additional search filters in the toolbar #13233

Conversation

upalatucci commented Oct 12, 2023 • edited

upalatucci commented Oct 12, 2023

upalatucci commented Oct 13, 2023

spadgett commented Oct 13, 2023

vojtechszocs Dec 11, 2023

Choose a reason for hiding this comment

upalatucci Jan 12, 2024

Choose a reason for hiding this comment

upalatucci commented Jan 17, 2024

upalatucci commented Jan 18, 2024

upalatucci commented Jan 19, 2024

upalatucci commented Jan 24, 2024

openshift-ci-robot commented Feb 7, 2024 • edited by openshift-ci bot

upalatucci commented Feb 7, 2024

upalatucci commented Feb 8, 2024

upalatucci commented Feb 9, 2024

upalatucci commented Feb 12, 2024

upalatucci commented Feb 13, 2024

upalatucci commented Feb 15, 2024

upalatucci commented Feb 20, 2024

upalatucci commented Feb 21, 2024

upalatucci commented Feb 22, 2024

vojtechszocs commented Feb 28, 2024

openshift-ci bot commented Feb 28, 2024

upalatucci commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot

upalatucci commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot

upalatucci commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024

openshift-ci bot commented Feb 29, 2024

openshift-ci-robot commented Feb 29, 2024

openshift-bot commented Feb 29, 2024

openshift-merge-robot commented Mar 5, 2024

upalatucci commented Oct 12, 2023 •

edited

openshift-ci-robot commented Feb 7, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot