Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-22419: Fix the forms when BC is not installed in the cluster #13241

Merged
merged 1 commit into from
Oct 26, 2023
Merged

OCPBUGS-22419: Fix the forms when BC is not installed in the cluster #13241

merged 1 commit into from
Oct 26, 2023

Conversation

Lucifergene
Copy link
Contributor

@Lucifergene Lucifergene commented Oct 13, 2023 •
edited
Loading

Fixes:
https://issues.redhat.com/browse/ODC-7397

Solution Description:

  • Hide the Samples Items (Builder Images & Devfiles)
  • Hide Upload JAR
  • Hide the Builder Images & Devfiles from Developer Catalog

Test setup:

  1. Start a cluster without Builds

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 13, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2023 •
edited by openshift-ci bot
Loading

@Lucifergene: This pull request references ODC-7397 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7397

Solution Description:

  • Hide the Samples Items (Builder Images & Devfiles)
  • Hide Upload JAR
  • Hide the Builder Images & Devfiles from Developer Catalog

Test setup:

  1. Start a cluster without Builds

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2023 •
edited by openshift-ci bot
Loading

@Lucifergene: This pull request references ODC-7397 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7397

Solution Description:

  • Hide the Samples Items (Builder Images & Devfiles)
  • Hide Upload JAR
  • Hide the Builder Images & Devfiles from Developer Catalog

Test setup:

  1. Start a cluster without Builds

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Oct 13, 2023
@Lucifergene
Copy link
Contributor Author

/cc @lokanandaprabhu @jerolimov

jerolimov
jerolimov suggested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in our huddle, it would be great if you could hide the samples from the Add page > Getting started section.

Currently it looks like this:

image

With an additional length check in SampleGettingStartedCard.tsx it can look like this:

image

It's difficult to hide the "Samples" card because other plugins might add a sample. But there is an option to hide if on the "Cluster configuration" page (/cluster-configuration/developer). So we can keep that "Samples" card.

@Lucifergene Lucifergene changed the title ODC-7397: Fix the forms when BC is not installed in the cluster OCPBUGS-22419: Fix the forms when BC is not installed in the cluster Oct 26, 2023
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: This pull request references Jira Issue OCPBUGS-22419, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7397

Solution Description:

  • Hide the Samples Items (Builder Images & Devfiles)
  • Hide Upload JAR
  • Hide the Builder Images & Devfiles from Developer Catalog

Test setup:

  1. Start a cluster without Builds

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 26, 2023
@Lucifergene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 26, 2023
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: This pull request references Jira Issue OCPBUGS-22419, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lucifergene
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@Lucifergene: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov
jerolimov approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 351effc into openshift:master Oct 26, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: Jira Issue OCPBUGS-22419: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22419 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7397

Solution Description:

  • Hide the Samples Items (Builder Images & Devfiles)
  • Hide Upload JAR
  • Hide the Builder Images & Devfiles from Developer Catalog

Test setup:

  1. Start a cluster without Builds

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Lucifergene: new pull request created: #13288

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 26, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-27-135451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lucifergene @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot @jerolimov