Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3788: migrate console Protractor tests to Cypress #13257

Merged
merged 3 commits into from Oct 27, 2023
Merged

CONSOLE-3788: migrate console Protractor tests to Cypress #13257

merged 3 commits into from Oct 27, 2023

Conversation

rhamilto
Copy link
Member

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2023 •
edited by openshift-ci bot

@rhamilto: This pull request references CONSOLE-3788 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@openshift-ci openshift-ci bot added kind/cypress Related to Cypress e2e integration testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2023
@cyril-ui-developer
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring labels Oct 19, 2023
@rhamilto
Copy link
Member Author

/retest

1 similar comment
@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto force-pushed the CONSOLE-3788 branch 2 times, most recently from 3f5463e to cc7a315 Compare October 23, 2023 19:59
@rhamilto rhamilto changed the title [WIP] CONSOLE-3788: migrate console Protractor tests to Cypress CONSOLE-3788: migrate console Protractor tests to Cypress Oct 25, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@rhamilto
Copy link
Member Author

Work is tech debt and has no customer-facing impact.

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 25, 2023 •
edited by openshift-ci bot

@rhamilto: This pull request references CONSOLE-3788 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto mentioned this pull request Oct 25, 2023
Merged
@cyril-ui-developer
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@rhamilto rhamilto mentioned this pull request Oct 25, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9994ddc and 2 for PR HEAD 14906b4 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
jhadvig
jhadvig approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos @rhamilto for this big change 🙌
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit d051f6d into openshift:master Oct 27, 2023
6 checks passed
@rhamilto rhamilto deleted the CONSOLE-3788 branch October 27, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyril-ui-developer cyril-ui-developer cyril-ui-developer left review comments

@jhadvig jhadvig jhadvig approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@jhadvig jhadvig

@cyril-ui-developer cyril-ui-developer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhamilto @openshift-ci-robot @cyril-ui-developer @jhadvig