OCPBUGS-22284: updating doc links for 4.14 GA #13266

kalexand-rh · 2023-10-20T17:52:37Z

Based on the docs previews, some of the doc links will be different in 4.14. This PR reflects what the new links are most likely going to be for both the downstream and upstream changes.

Because of the difficulties in redirecting links in the access.redhat.com version of the docs, we'll need to update the console.

https://issues.redhat.com/browse/OSDOCS-8149

See https://redhat-internal.slack.com/archives/C6A3NV5J9/p1696863838391269 for some context.

frontend/public/components/utils/documentation.tsx

rhamilto · 2023-10-22T14:33:06Z

/retest
/lgtm

rhamilto · 2023-10-22T14:46:42Z

frontend/public/components/utils/documentation.tsx

  },
  updateUsingCustomMachineConfigPools: {
-    downstream: 'html/updating_clusters/update-using-custom-machine-config-pools.html',
-    upstream: 'updating/update-using-custom-machine-config-pools.html',
+    downstream: 'html/updating_clusters/performing-a-cluster-update#update-using-custom-machine-config-pools',


Lint fix is required:

Suggested change

downstream: 'html/updating_clusters/performing-a-cluster-update#update-using-custom-machine-config-pools',

downstream:

'html/updating_clusters/performing-a-cluster-update#update-using-custom-machine-config-pools',

kalexand-rh · 2023-10-23T14:08:05Z

/test frontend

kalexand-rh · 2023-10-23T14:08:38Z

/label docs-approved

kalexand-rh · 2023-10-23T15:36:42Z

@kalexand-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend ab34de8 link true /test frontend
Full PR test history. Your PR dashboard.

~~@rhamilto, I'm not familiar with this error. Will you PTAL and let me know if we need to change the code or if I need to rerun it until it passes?~~ Sorry, I see your correction now.

OSDOCS-8149: hide update service link for upstream

kalexand-rh · 2023-10-23T18:48:39Z

@rhamilto, will you please take another look and suggest the right QE reviewer?

kalexand-rh · 2023-10-23T18:48:44Z

/jira refresh

openshift-ci-robot · 2023-10-23T18:48:46Z

@kalexand-rh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-23T18:49:10Z

@kalexand-rh: This pull request references OSDOCS-8149 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

Based on the docs previews, some of the doc links will be different in 4.14. This PR reflects what the new links are most likely going to be for both the downstream and upstream changes.

Because of the difficulties in redirecting links in the access.redhat.com version of the docs, we'll need to update the console.

https://issues.redhat.com/browse/OSDOCS-8149

See https://redhat-internal.slack.com/archives/C6A3NV5J9/p1696863838391269 for some context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kalexand-rh · 2023-10-23T18:49:17Z

/jira refresh

openshift-ci-robot · 2023-10-23T18:49:20Z

@kalexand-rh: This pull request references OSDOCS-8149 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kalexand-rh · 2023-10-23T18:51:16Z

4.15.0 is not a valid target version for the OSDOCS project.

openshift-ci · 2023-10-23T19:22:09Z

@kalexand-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rhamilto · 2023-10-23T19:54:35Z

/lgtm

openshift-ci-robot · 2023-10-23T19:57:46Z

@kalexand-rh: This pull request references Jira Issue OCPBUGS-22284, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Based on the docs previews, some of the doc links will be different in 4.14. This PR reflects what the new links are most likely going to be for both the downstream and upstream changes.

Because of the difficulties in redirecting links in the access.redhat.com version of the docs, we'll need to update the console.

https://issues.redhat.com/browse/OSDOCS-8149

See https://redhat-internal.slack.com/archives/C6A3NV5J9/p1696863838391269 for some context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kalexand-rh · 2023-10-23T19:57:49Z

/jira refresh

openshift-ci-robot · 2023-10-23T19:57:52Z

@kalexand-rh: This pull request references Jira Issue OCPBUGS-22284, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kalexand-rh · 2023-10-23T19:58:21Z

/jira refresh

openshift-ci-robot · 2023-10-23T19:58:25Z

@kalexand-rh: This pull request references Jira Issue OCPBUGS-22284, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-10-23T20:14:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kalexand-rh, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-10-23T20:35:51Z

@kalexand-rh: Jira Issue OCPBUGS-22284: All pull requests linked via external trackers have merged:

openshift/console#13266

Jira Issue OCPBUGS-22284 has been moved to the MODIFIED state.

In response to this:

Based on the docs previews, some of the doc links will be different in 4.14. This PR reflects what the new links are most likely going to be for both the downstream and upstream changes.

Because of the difficulties in redirecting links in the access.redhat.com version of the docs, we'll need to update the console.

https://issues.redhat.com/browse/OSDOCS-8149

See https://redhat-internal.slack.com/archives/C6A3NV5J9/p1696863838391269 for some context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2023-10-23T20:54:39Z

/cherry-pick release-4.14

openshift-cherrypick-robot · 2023-10-23T20:55:35Z

@rhamilto: new pull request created: #13273

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-10-25T05:26:50Z

Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302

openshift-ci bot requested review from jeff-phillips-18 and TheRealJon October 20, 2023 17:52

openshift-ci bot added the component/core Related to console core functionality label Oct 20, 2023

rhamilto reviewed Oct 20, 2023

View reviewed changes

frontend/public/components/utils/documentation.tsx Show resolved Hide resolved

kalexand-rh force-pushed the OSDOCS-8149 branch from bccb7aa to ab34de8 Compare October 20, 2023 20:32

openshift-ci bot assigned rhamilto Oct 22, 2023

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2023

rhamilto reviewed Oct 22, 2023

View reviewed changes

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 23, 2023

OSDOCS-8149 - updating doc links for 4.14 GA

3a5001f

OSDOCS-8149: hide update service link for upstream

kalexand-rh force-pushed the OSDOCS-8149 branch from ab34de8 to 3a5001f Compare October 23, 2023 15:38

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023

kalexand-rh changed the title ~~OSDOCS-8149 - updating doc links for 4.14 GA~~ OSDOCS-8149: updating doc links for 4.14 GA Oct 23, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2023

kalexand-rh changed the title ~~OSDOCS-8149: updating doc links for 4.14 GA~~ OCPBUGS-22284: updating doc links for 4.14 GA Oct 23, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 23, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 23, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023

openshift-ci bot merged commit 175a6a2 into openshift:master Oct 23, 2023
6 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 23, 2023

[release-4.14] OCPBUGS-22285: updating doc links for 4.14 GA #13273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-22284: updating doc links for 4.14 GA #13266

OCPBUGS-22284: updating doc links for 4.14 GA #13266

kalexand-rh commented Oct 20, 2023

rhamilto commented Oct 22, 2023

rhamilto Oct 22, 2023

kalexand-rh commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023 •

edited

kalexand-rh commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023 •

edited by openshift-ci bot

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023 •

edited by openshift-ci bot

kalexand-rh commented Oct 23, 2023

openshift-ci bot commented Oct 23, 2023

rhamilto commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

openshift-ci bot commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

rhamilto commented Oct 23, 2023

openshift-cherrypick-robot commented Oct 23, 2023

openshift-merge-robot commented Oct 25, 2023

	downstream: 'html/updating_clusters/performing-a-cluster-update#update-using-custom-machine-config-pools',
	downstream:
	'html/updating_clusters/performing-a-cluster-update#update-using-custom-machine-config-pools',

OCPBUGS-22284: updating doc links for 4.14 GA #13266

OCPBUGS-22284: updating doc links for 4.14 GA #13266

Conversation

kalexand-rh commented Oct 20, 2023

rhamilto commented Oct 22, 2023

rhamilto Oct 22, 2023

Choose a reason for hiding this comment

kalexand-rh commented Oct 23, 2023

/test frontend

kalexand-rh commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023 • edited

kalexand-rh commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023 • edited by openshift-ci bot

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023 • edited by openshift-ci bot

kalexand-rh commented Oct 23, 2023

openshift-ci bot commented Oct 23, 2023

rhamilto commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

kalexand-rh commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

openshift-ci bot commented Oct 23, 2023

openshift-ci-robot commented Oct 23, 2023

rhamilto commented Oct 23, 2023

openshift-cherrypick-robot commented Oct 23, 2023

openshift-merge-robot commented Oct 25, 2023

kalexand-rh commented Oct 23, 2023 •

edited

openshift-ci-robot commented Oct 23, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 23, 2023 •

edited by openshift-ci bot