New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.13] OCPBUGS-22241: Save also the location.search and .hash values in localStorage to restore them after login #13271
[release-4.13] OCPBUGS-22241: Save also the location.search and .hash values in localStorage to restore them after login #13271
Conversation
…tore them after login
@jerolimov: This pull request references Jira Issue OCPBUGS-22241, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
Verified this change on a cluster bot instance: cluster-bot-pr-13271.mp4A recording of the broken version is available on #13268 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/jira refresh |
@jerolimov: This pull request references Jira Issue OCPBUGS-22241, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jerolimov: This pull request references Jira Issue OCPBUGS-22241, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label qe-approved |
/label cherry-pick-approved |
@jerolimov: This pull request references Jira Issue OCPBUGS-22241, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jerolimov: This pull request references Jira Issue OCPBUGS-22241, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2ce2211
into
openshift:release-4.13
@jerolimov: Jira Issue OCPBUGS-22241: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22241 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.13.0-202312080734.p0.g2ce2211.assembly.stream for distgit openshift-enterprise-console. |
Fix included in accepted release 4.13.0-0.nightly-2023-12-11-165920 |
Fixes:
https://issues.redhat.com/browse/OCPBUGS-22241
This is a manual cherry-pick of #13270 because an automatic cherry-pick will not work because of a tiny conflict.
The comment
// TODO remove multicluster
wasn't part of 4.13. 😆/cc @lokanandaprabhu @sanketpathak @jhadvig