Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7359: Fix shipwright build e2e tests #13296

Merged
merged 1 commit into from Nov 26, 2023
Merged

ODC-7359: Fix shipwright build e2e tests #13296

merged 1 commit into from Nov 26, 2023

Conversation

sanketpathak
Copy link
Contributor

Issue: https://issues.redhat.com/browse/ODC-7359
Epic: https://issues.redhat.com/browse/ODC-7358

Test Setup:

export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.jephilli-4-11-02-23-0643.devcluster.openshift.com/
export BRIDGE_KUBEADMIN_PASSWORD
export BRIDGE_BASE_ADDRESS
oc login https://api.jephilli-4-10-02-23-0643.devcluster.openshift.com:6443/ -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
  
#Execute below commands under console folder
oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
  
./test-cypress.sh -p shipwright

Test Execution Screenshot:
Screenshot 2023-10-31 at 2 59 43 AM
Screenshot 2023-10-29 at 4 58 19 AM

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2023
@jerolimov
Copy link
Member

Can we also re-enable it in test-cypress.sh, or is it still to flaky or slow?

/cc @The-Anton

@openshift-ci openshift-ci bot requested a review from The-Anton October 31, 2023 15:46
jerolimov
jerolimov reviewed Oct 31, 2023
View reviewed changes
...ght-plugin/integration-tests/support/step-definitions/builds/shipwright-build-detail-page.ts
Comment on lines 122 to +124
failOnNonZeroExit: false,
}).then(function (result) {
cy.log(result.stdout);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this fail on errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is just to show the cli result in cypress logs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But above is a failOnNonZeroExit: false 😏

But we can also create a tech debt issue for that and try to remove all failOnNonZeroExit: false in the next release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not changed it so as to not stop the execution of further statements but also see logs in cypress logs

@sanketpathak sanketpathak force-pushed the e2e-shipwright-ci-test-fixation branch from b24796a to 2a2d8c1 Compare October 31, 2023 20:38
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@jerolimov
Copy link
Member

In general, this is great. Please check why the tests are broken.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@jerolimov jerolimov mentioned this pull request Nov 4, 2023
Merged
8 tasks
@sanketpathak
Copy link
Contributor Author

/retest

@sanketpathak sanketpathak force-pushed the e2e-shipwright-ci-test-fixation branch 2 times, most recently from 8cbce57 to 107e036 Compare November 7, 2023 11:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2023
@jerolimov
Copy link
Member

jerolimov commented Nov 12, 2023 •
edited by openshift-ci bot

/retitle ODC-7359: Fix shipwright build e2e tests

@sanketpathak We can not reenable this because it depends on the Pipelines operator and this isn't available currently. When you revert the change that enable this tests we can merge the rest anyway. Wdyt?

@openshift-ci openshift-ci bot changed the title Fix shipwright build e2e tests ODC-7359: Fix shipwright build e2e tests Nov 12, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2023 •
edited by openshift-ci bot

@sanketpathak: This pull request references ODC-7359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Issue: https://issues.redhat.com/browse/ODC-7359
Epic: https://issues.redhat.com/browse/ODC-7358

Test Setup:

export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.jephilli-4-11-02-23-0643.devcluster.openshift.com/
export BRIDGE_KUBEADMIN_PASSWORD
export BRIDGE_BASE_ADDRESS
oc login https://api.jephilli-4-10-02-23-0643.devcluster.openshift.com:6443/ -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
 
#Execute below commands under console folder
oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
 
./test-cypress.sh -p shipwright

Test Execution Screenshot:
Screenshot 2023-10-31 at 2 59 43 AM
Screenshot 2023-10-29 at 4 58 19 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2023
@jerolimov
Copy link
Member

/cc @The-Anton @Lucifergene

@sanketpathak
Copy link
Contributor Author

/retest

2 similar comments
@sanketpathak
Copy link
Contributor Author

/retest

@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

jerolimov commented Nov 21, 2023 •
edited

Because it just updates the integration tests

/label acknowledge-critical-fixes-only
/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2023
@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci bot

@sanketpathak: This pull request references ODC-7359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Issue: https://issues.redhat.com/browse/ODC-7359
Epic: https://issues.redhat.com/browse/ODC-7358

Test Setup:

export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.jephilli-4-11-02-23-0643.devcluster.openshift.com/
export BRIDGE_KUBEADMIN_PASSWORD
export BRIDGE_BASE_ADDRESS
oc login https://api.jephilli-4-10-02-23-0643.devcluster.openshift.com:6443/ -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
 
#Execute below commands under console folder
oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
 
./test-cypress.sh -p shipwright

Test Execution Screenshot:
Screenshot 2023-10-31 at 2 59 43 AM
Screenshot 2023-10-29 at 4 58 19 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@The-Anton
Copy link
Member

All tests are passing.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, sanketpathak, The-Anton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 14e9bd7 and 2 for PR HEAD cff9bc4 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b5045f2 and 1 for PR HEAD cff9bc4 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 99b8f87 and 0 for PR HEAD cff9bc4 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision cff9bc4 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2023
@jerolimov
Copy link
Member

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2023

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cf96105 into openshift:master Nov 26, 2023
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311260250.p0.gcf96105.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov left review comments

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

@The-Anton The-Anton Awaiting requested review from The-Anton

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

Assignees

@The-Anton The-Anton

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sanketpathak @jerolimov @openshift-ci-robot @The-Anton @openshift-bot @openshift-merge-robot