New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7423: move pipelinerun results to output tab #13323
ODC-7423: move pipelinerun results to output tab #13323
Conversation
@karthikjeeyar: This pull request references ODC-7423 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
36ac9a8
to
69bb0da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, karthikjeeyar, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Propagate from the epic /label docs-approved If the tests passes this is fine for now, also if an e2e test would be nice. Let us merge this change before the next stabilization phase requires additional reviews and labels... /label qe-approved |
@karthikjeeyar: This pull request references ODC-7423 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
@karthikjeeyar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311130831.p0.g84d49e7.assembly.stream for distgit openshift-enterprise-console. |
Fixes:
https://issues.redhat.com/browse/ODC-7423
Analysis / Root cause:
Move pipelinerun results section to new output tab.
Solution Description:
Used static tab extension to add Output tab, this output tab will be replaced by the dynamic plugin extension with a generic output renderer logic in future.
NOTE: dynamic plugin must expose the feature Flag called
CONSOLE_PIPELINE_PLUGIN
so that it will hide the static tab and load the tab from dynamic extension.Screen shots / Gifs for design review:
Before:
After:
Unit test coverage report:
Test setup:
Browser conformance: