Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7423: move pipelinerun results to output tab #13323

Merged
merged 1 commit into from Nov 13, 2023

Conversation

karthikjeeyar
Copy link
Contributor

Fixes:

https://issues.redhat.com/browse/ODC-7423

Analysis / Root cause:

Move pipelinerun results section to new output tab.

Solution Description:

Used static tab extension to add Output tab, this output tab will be replaced by the dynamic plugin extension with a generic output renderer logic in future.

NOTE: dynamic plugin must expose the feature Flag called CONSOLE_PIPELINE_PLUGIN so that it will hide the static tab and load the tab from dynamic extension.

Screen shots / Gifs for design review:

Before:

results_in_plr_details

After:

Screenshot 2023-11-10 at 8 31 07 PM

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2023

@karthikjeeyar: This pull request references ODC-7423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7423

Analysis / Root cause:

Move pipelinerun results section to new output tab.

Solution Description:

Used static tab extension to add Output tab, this output tab will be replaced by the dynamic plugin extension with a generic output renderer logic in future.

NOTE: dynamic plugin must expose the feature Flag called CONSOLE_PIPELINE_PLUGIN so that it will hide the static tab and load the tab from dynamic extension.

Screen shots / Gifs for design review:

Before:

results_in_plr_details

After:

Screenshot 2023-11-10 at 8 31 07 PM

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2023
@karthikjeeyar
Copy link
Contributor Author

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2023
Copy link
Contributor

openshift-ci bot commented Nov 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, karthikjeeyar, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerolimov
Copy link
Member

jerolimov commented Nov 11, 2023

Propagate from the epic

/label docs-approved
/label px-approved

If the tests passes this is fine for now, also if an e2e test would be nice. Let us merge this change before the next stabilization phase requires additional reviews and labels...

/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 11, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 11, 2023

@karthikjeeyar: This pull request references ODC-7423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-7423

Analysis / Root cause:

Move pipelinerun results section to new output tab.

Solution Description:

Used static tab extension to add Output tab, this output tab will be replaced by the dynamic plugin extension with a generic output renderer logic in future.

NOTE: dynamic plugin must expose the feature Flag called CONSOLE_PIPELINE_PLUGIN so that it will hide the static tab and load the tab from dynamic extension.

Screen shots / Gifs for design review:

Before:

results_in_plr_details

After:

Screenshot 2023-11-10 at 8 31 07 PM

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ccebf14 and 2 for PR HEAD 69bb0da in total

@jerolimov
Copy link
Member

/retest

1 similar comment
@jerolimov
Copy link
Member

/retest

Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

@karthikjeeyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 84d49e7 into openshift:master Nov 13, 2023
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311130831.p0.g84d49e7.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants