Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7383: add support for tektonresult api to load TaskRuns #13324

Closed
wants to merge 1 commit into from

Conversation

vikram-raj
Copy link
Member

Story: https://issues.redhat.com/browse/ODC-7383

Descriptions:

Add support to fetch TaskRuns using the TektonResults API endpoint in the TaskRun list page, TaskRuns list on the PipelineRun details page.

Test setup:

  1. Install Red Hat Openshift Pipeline Operator in the console
  2. Install Tekton Results in the console using this gist https://gist.github.com/vikram-raj/257d672a38eb2159b0368eaed8f8970a
  3. Create Pipeline and PipelineRuns and try out all the features.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2023

@vikram-raj: This pull request references ODC-7383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7383

Descriptions:

Add support to fetch TaskRuns using the TektonResults API endpoint in the TaskRun list page, TaskRuns list on the PipelineRun details page.

Test setup:

  1. Install Red Hat Openshift Pipeline Operator in the console
  2. Install Tekton Results in the console using this gist https://gist.github.com/vikram-raj/257d672a38eb2159b0368eaed8f8970a
  3. Create Pipeline and PipelineRuns and try out all the features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2023
@vikram-raj
Copy link
Member Author

@openshift-ci openshift-ci bot requested review from jerolimov and karthikjeeyar and removed request for andrewballantyne and abhinandan13jan November 13, 2023 07:36
@vikram-raj
Copy link
Member Author

/retest

@vikram-raj vikram-raj changed the title ODC-7383: add support for tektonresult api to load PipelineRuns ODC-7383: add support for tektonresult api to load TaskRuns Nov 13, 2023
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Nov 15, 2023
@karthikjeeyar
Copy link
Contributor

I can see infinite calls to tekton-results API in pipelineRuns -> taskRuns tab

image

@karthikjeeyar
Copy link
Contributor

I think Search page -> TaskRuns list is using default resource list component so the tekton-results call is missing here, do we want to use the same TaskRunList component (with tekton-results) for search page as well?

image

@karthikjeeyar
Copy link
Contributor

Search Page -> PipelineRun list makes tekton-results to API call but the data is not rendered in the list view.

image

Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj vikram-raj force-pushed the odc-7383 branch 2 times, most recently from ed34c3e to 91fe160 Compare November 17, 2023 13:03
@vikram-raj
Copy link
Member Author

@karthikjeeyar Regarding the search page. That is expected. We are not showing the data from the result database in the search page list as on the search page we only show k8s data.

@vikram-raj
Copy link
Member Author

I fixed the infinite network call and added changes to @lokanandaprabhu PR #13328 in the commit 7c77c26 as we shared the utils for both the PR.

@vikram-raj
Copy link
Member Author

/close

We merge these changes in the PR #13328

@openshift-ci openshift-ci bot closed this Nov 17, 2023
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@vikram-raj: Closed this PR.

In response to this:

/close

We merge these changes in the PR #13328

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants