Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7424: add e2e tests for SBOM section and output tab #13325

Merged

Conversation

karthikjeeyar
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-7424

Adds e2e test cases for SBOM and Output tab.

cc: @sanketpathak

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2023

@karthikjeeyar: This pull request references ODC-7424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7424

Adds e2e test cases for SBOM and Output tab.

cc: @sanketpathak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2023
@sanketpathak
Copy link
Contributor

Tests run green
Screenshot 2023-11-15 at 7 24 38 PM

/lgtm

@sanketpathak
Copy link
Contributor

PR only updates e2e tests
/label qe-approved
/label docs-approved
/label px-approved

@sanketpathak
Copy link
Contributor

/label acknowledge-critical-fixes

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 15, 2023

@karthikjeeyar: This pull request references ODC-7424 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7424

Adds e2e test cases for SBOM and Output tab.

cc: @sanketpathak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

@sanketpathak: The label(s) /label acknowledge-critical-fixes cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label acknowledge-critical-fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 15, 2023
@sanketpathak
Copy link
Contributor

/label acknowledge-critical-fixes-only

@sanketpathak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 15, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fdcd773 and 2 for PR HEAD ec7d110 in total

@karthikjeeyar
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

@karthikjeeyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 100ffa6 into openshift:master Nov 16, 2023
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311161132.p0.g100ffa6.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants