Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7421: Show vulnerability column in the pipelinerun list page #13329

Merged

Conversation

jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Nov 14, 2023

Fixes:
Fixes ODC-7421

Adds a vulnerability column and a signed indicator column to the pipeline run list page.
Adds a View SBOM action on pipeline runs.
Adds a Vulnerabilities section to the pipeline run details page.

image

image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2023

@jeff-phillips-18: This pull request references ODC-7421 which is a valid jira issue.

In response to this:

Fixes:
Fixes ODC-7421

Adds a vulnerability column and a signed indicator column to the pipeline run list page.
Adds a View SBOM action on pipeline runs.

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-phillips-18
Copy link
Member Author

/cc @beaumorley @MariaLeonova

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Nov 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2023

@jeff-phillips-18: This pull request references ODC-7421 which is a valid jira issue.

In response to this:

Fixes:
Fixes ODC-7421

Adds a vulnerability column and a signed indicator column to the pipeline run list page.
Adds a View SBOM action on pipeline runs.
Adds a Vulnerabilities section to the pipeline run details page.

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2023

@jeff-phillips-18: This pull request references ODC-7421 which is a valid jira issue.

In response to this:

Fixes:
Fixes ODC-7421

Adds a vulnerability column and a signed indicator column to the pipeline run list page.
Adds a View SBOM action on pipeline runs.
Adds a Vulnerabilities section to the pipeline run details page.

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Nov 14, 2023
@jeff-phillips-18
Copy link
Member Author

Updated signed badge location per @MariaLeonova, screen shot updated above.

Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@karthikjeeyar
Copy link
Contributor

cc: @vdemeester

@invincibleJai
Copy link
Member

/cc @vikram-raj

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified it

/approve

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, karthikjeeyar, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@vikram-raj
Copy link
Member

/retest

@vikram-raj
Copy link
Member

Propagate from the epic

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 15, 2023
@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 15, 2023
@vikram-raj
Copy link
Member

/assign @sanketpathak for qe-approved

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

@vikram-raj: GitHub didn't allow me to assign the following users: for, qe-approved.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sanketpathak for qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@beaumorley
Copy link

LGTM thank you

@invincibleJai
Copy link
Member

/retest

@sanketpathak
Copy link
Contributor

Verified with admin and non-admin user
Screenshot 2023-11-16 at 2 51 52 PM

Screenshot 2023-11-16 at 2 54 35 PM

Tests will be added as separate pr
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 16, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 16, 2023

@jeff-phillips-18: This pull request references ODC-7421 which is a valid jira issue.

In response to this:

Fixes:
Fixes ODC-7421

Adds a vulnerability column and a signed indicator column to the pipeline run list page.
Adds a View SBOM action on pipeline runs.
Adds a Vulnerabilities section to the pipeline run details page.

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 16, 2023
Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

@jeff-phillips-18: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b85b6f7 into openshift:master Nov 16, 2023
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311161809.p0.gb85b6f7.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@jeff-phillips-18 jeff-phillips-18 deleted the pipeline-cves branch November 17, 2023 12:14
@MariaLeonova
Copy link

@jeff-phillips-18, looks great!
Do you think it would be feasible to add a link to View logs on the details page, too?
Screenshot 2023-11-20 at 9 21 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants