Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23164: Cannot Edit Shipwright Build #13341

Merged

Conversation

Lucifergene
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-23164

Analysis / Root cause:
Cannot Edit Shipwright Build/BuildRun by clicking the "Edit Build/BuildRun" from the Actions Menu.

Solution Description:
Updated the setting to allow the respective resources to be edited in the YAML editor.

Screen shots / Gifs for design review:

Tab-Builds.Shipwright.Builds.OKD.2.mp4

Unit test coverage report:
Not changed.

Test setup:

  1. Create a SW Build
  2. Click the "Edit Build" from the Actions Menu.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 17, 2023
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: This pull request references Jira Issue OCPBUGS-23164, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-23164

Analysis / Root cause:
Cannot Edit Shipwright Build/BuildRun by clicking the "Edit Build/BuildRun" from the Actions Menu.

Solution Description:
Updated the setting to allow the respective resources to be edited in the YAML editor.

Screen shots / Gifs for design review:

Tab-Builds.Shipwright.Builds.OKD.2.mp4

Unit test coverage report:
Not changed.

Test setup:

  1. Create a SW Build
  2. Click the "Edit Build" from the Actions Menu.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lucifergene
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@Lucifergene: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
@jerolimov
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 17, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2561bbd and 2 for PR HEAD b241b8c in total

@Lucifergene
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 18, 2023

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0dee46c into openshift:master Nov 18, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@Lucifergene: Jira Issue OCPBUGS-23164: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23164 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-23164

Analysis / Root cause:
Cannot Edit Shipwright Build/BuildRun by clicking the "Edit Build/BuildRun" from the Actions Menu.

Solution Description:
Updated the setting to allow the respective resources to be edited in the YAML editor.

Screen shots / Gifs for design review:

Tab-Builds.Shipwright.Builds.OKD.2.mp4

Unit test coverage report:
Not changed.

Test setup:

  1. Create a SW Build
  2. Click the "Edit Build" from the Actions Menu.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Lucifergene: new pull request created: #13343

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311181409.p0.g0dee46c.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-18-191907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants