OCPBUGS-23388: Pipeline Name gets changed to "new-pipeline" on the Edit Pipeline YAML/Builder

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-23388

Analysis / Root cause:
On edit pipeline, in yaml editor, existing pipeline name was not considered

Solution Description:
Updated edit pipeline to not not change name while edit in YAML editor

Screen shots / Gifs for design review:
----BEFORE---

https://drive.google.com/file/d/19-dI8lSdH6tAZm3T8CQHw78P2AzdSIRv/view?usp=sharing

----AFTER----

Screen.Recording.2023-11-20.at.4.38.40.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create Task 1: https://tekton.dev/docs/getting-started/tasks/#create-and-run-a-basic-task
2. Create Task 2: https://tekton.dev/docs/getting-started/pipelines/#create-and-run-a-second-task
3. Create Pipeline: https://tekton.dev/docs/getting-started/pipelines/#create-and-run-a-pipeline
4. Click "Edit Pipeline" from the Actions Menu

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-23388, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-23388

Analysis / Root cause:
On edit pipeline, in yaml editor, existing pipeline name was not considered

Solution Description:
Updated edit pipeline to not not change name while edit in YAML editor

Screen shots / Gifs for design review:
----BEFORE---

https://drive.google.com/file/d/19-dI8lSdH6tAZm3T8CQHw78P2AzdSIRv/view?usp=sharing

----AFTER----

Screen.Recording.2023-11-20.at.4.38.40.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create Task 1: https://tekton.dev/docs/getting-started/tasks/#create-and-run-a-basic-task
2. Create Task 2: https://tekton.dev/docs/getting-started/pipelines/#create-and-run-a-second-task
3. Create Pipeline: https://tekton.dev/docs/getting-started/pipelines/#create-and-run-a-pipeline
4. Click "Edit Pipeline" from the Actions Menu

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lokanandaprabhu]

/retest

[jerolimov]

Not tested, but in general fine with that solution.

/approve

[jerolimov]

/label acknowledge-critical-fixes-only

[Lucifergene]

Verified :)

Tab-hello-goodbye.Pipeline.Details.Red.Hat.OpenShift.mp4

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 224da7e and 2 for PR HEAD 8098e2d in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD da64743 and 1 for PR HEAD 8098e2d in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 51ca6ff and 0 for PR HEAD 8098e2d in total

[openshift-ci-robot]

/hold

Revision 8098e2d was retested 3 times: holding

[lokanandaprabhu]

/unhold
/retest

[lokanandaprabhu]

/retest

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jerolimov]

Reapply @Lucifergene s lgtm after rebase.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu, Lucifergene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-23388: All pull requests linked via external trackers have merged:

• openshift/console#13344

Jira Issue OCPBUGS-23388 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-23388

Analysis / Root cause:
On edit pipeline, in yaml editor, existing pipeline name was not considered

Solution Description:
Updated edit pipeline to not not change name while edit in YAML editor

Screen shots / Gifs for design review:
----BEFORE---

https://drive.google.com/file/d/19-dI8lSdH6tAZm3T8CQHw78P2AzdSIRv/view?usp=sharing

----AFTER----

Screen.Recording.2023-11-20.at.4.38.40.PM.mov

Unit test coverage report:
NA

Test setup:

1. Create Task 1: https://tekton.dev/docs/getting-started/tasks/#create-and-run-a-basic-task
2. Create Task 2: https://tekton.dev/docs/getting-started/pipelines/#create-and-run-a-second-task
3. Create Pipeline: https://tekton.dev/docs/getting-started/pipelines/#create-and-run-a-pipeline
4. Click "Edit Pipeline" from the Actions Menu

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311232232.p0.gc1b77d8.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-11-24-034436

[Lucifergene]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@Lucifergene: new pull request created: #13585

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.