Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-23483: add access to create, edit and delete silences for developer user from developer perspective #13349

Merged
merged 1 commit into from Jan 4, 2024
Merged

[release-4.13] OCPBUGS-23483: add access to create, edit and delete silences for developer user from developer perspective #13349

merged 1 commit into from Jan 4, 2024

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Nov 21, 2023 •
edited

manual cherry-pick of PR #12900

NOTE: Not include complete PR. This PR includes only the changes that fix this issue https://issues.redhat.com//browse/OCPBUGS-23483

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring labels Nov 21, 2023
@vikram-raj vikram-raj force-pushed the cherry-pick-12900-to-release-4.13 branch from 29a797f to 71490c9 Compare November 21, 2023 07:51
@vikram-raj vikram-raj changed the title [release-4.13] add access to create, edit and delete silences for developer user from developer perspective [release-4.13] OCPBUGS-23483: add access to create, edit and delete silences for developer user from developer perspective Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-23483, which is invalid:

  • expected Jira Issue OCPBUGS-23483 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-23483, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19693 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-19693 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-23483, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19693 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-19693 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

manual cherry-pick of PR #12900

NOTE: Not include complete PR. This PR includes only the changes that fix this issue https://issues.redhat.com//browse/OCPBUGS-23483

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/cc @vikram-raj @lokanandaprabhu @Lucifergene
/assign @vikram-raj

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

@jerolimov: GitHub didn't allow me to request PR reviews from the following users: vikram-raj.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vikram-raj @lokanandaprabhu @Lucifergene
/assign @vikram-raj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/retest

5 similar comments
@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/label backport-risk-assessed
/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 12, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@vikram-raj vikram-raj force-pushed the cherry-pick-12900-to-release-4.13 branch from 71490c9 to 43b1c19 Compare December 15, 2023 12:27
@vikram-raj vikram-raj force-pushed the cherry-pick-12900-to-release-4.13 branch from 43b1c19 to 0e1e6f2 Compare December 20, 2023 08:56
@vikram-raj
Copy link
Member Author

/retest

1 similar comment
@vikram-raj
Copy link
Member Author

/retest

vikram-raj
vikram-raj commented Dec 22, 2023
View reviewed changes
Copy link
Member Author

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it on the cluster bot.

GH-13349.mov

@lokanandaprabhu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@The-Anton
Copy link
Member

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 4, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 68ed5d2 and 2 for PR HEAD 0e1e6f2 in total

@vikram-raj
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 071df39 into openshift:release-4.13 Jan 4, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-23483: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23483 has been moved to the MODIFIED state.

In response to this:

manual cherry-pick of PR #12900

NOTE: Not include complete PR. This PR includes only the changes that fix this issue https://issues.redhat.com//browse/OCPBUGS-23483

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.13.0-202401041553.p0.g071df39.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2024-01-04-170936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoto kyoto Awaiting requested review from kyoto

@rottencandy rottencandy Awaiting requested review from rottencandy

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

@lokanandaprabhu lokanandaprabhu Awaiting requested review from lokanandaprabhu

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

Assignees

@gouyang gouyang

@vikram-raj vikram-raj

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@juzhao juzhao

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet