Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23980: Fix logs streaming auto scroll issue #13377

Merged

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Nov 27, 2023

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23980

Problem:

logs container is not auto scrolling to the bottom of the page.

Solution:

Increase the throttle timeout to address the performance issue on high volume logs and set the autoscroll prop to true by default

Before:

Autoscroll feature is not working after few scroll operation.

logs_streaming_before_fix

After:

log_streaming_after_fix

Steps to test/reproduce:

  1. Use this pipelinerun - https://gist.github.com/karthikjeeyar/eb1bbdf9157431f5c875eb55ce47580c
  2. navigate to logs page

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2023
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Jira Issue OCPBUGS-23980, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23980

Problem:

logs container is not auto scrolling to the bottom of the page.

Solution:

Increase the throttle timeout to address the performance issue on high volume logs and set the autoscroll prop to true by default

Before:

Autoscroll feature is not working after few scroll operation.

logs_streaming_before_fix

After:

log_streaming_after_fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 27, 2023
@karthikjeeyar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 27, 2023
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Jira Issue OCPBUGS-23980, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor Author

/cc @lokanandaprabhu @vikram-raj

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 27, 2023
@karthikjeeyar
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Jira Issue OCPBUGS-23980, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23980

Problem:

logs container is not auto scrolling to the bottom of the page.

Solution:

Increase the throttle timeout to address the performance issue on high volume logs and set the autoscroll prop to true by default

Before:

Autoscroll feature is not working after few scroll operation.

logs_streaming_before_fix

After:

log_streaming_after_fix

Steps to test/reproduce:

  1. Use this pipelinerun - https://gist.github.com/karthikjeeyar/eb1bbdf9157431f5c875eb55ce47580c
  2. navigate to logs page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lokanandaprabhu
Copy link
Contributor

Tested locally.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@karthikjeeyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@karthikjeeyar
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 28, 2023
@karthikjeeyar
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 0e354b4 into openshift:master Nov 28, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: Jira Issue OCPBUGS-23980: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23980 has been moved to the MODIFIED state.

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-23980

Problem:

logs container is not auto scrolling to the bottom of the page.

Solution:

Increase the throttle timeout to address the performance issue on high volume logs and set the autoscroll prop to true by default

Before:

Autoscroll feature is not working after few scroll operation.

logs_streaming_before_fix

After:

log_streaming_after_fix

Steps to test/reproduce:

  1. Use this pipelinerun - https://gist.github.com/karthikjeeyar/eb1bbdf9157431f5c875eb55ce47580c
  2. navigate to logs page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202311282232.p0.g0e354b4.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants