OCPBUGS-18401: fix filtering issues on Events

[rhamilto]

In addition to the text filter not working, this PR also addresses:

• open websockets do not get closed when changing project or resource filter
• the type filter does not work
• pausing the stream does not work

After:

events.mov

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-18401, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/retest

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-18401, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

In response to this:

In addition to the text filter not working, this PR also addresses:

• open websockets do not get closed when changing project or resource filter
• the type filter does not work
• pausing the stream does not work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/retest

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-18401, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @XiyunZhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In addition to the text filter not working, this PR also addresses:

• open websockets do not get closed when changing project or resource filter
• the type filter does not work
• pausing the stream does not work

After:

events.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sg00dwin]

One behavior I did find is regarding when the Event stream is paused. If a resource is either added or removed, it triggers the event stream to become un paused.

I believe this is expected behavior as changing the resource filter results in the closing and reopening of the websocket.

[TheRealJon]

If this fixes the bug, we should go ahead and commit it, but this component still has some problematic patterns we need to address at some point.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TheRealJon]

Also could we create a follow-on story or another PR attached to this bug that adds at least a basic e2e test for the events page?

[rhamilto]

Also could we create a follow-on story or another PR attached to this bug that adds at least a basic e2e test for the events page?

Agreed. We do have a very basic test. But I punted on adding to it since it will require figuring out how to generate additional events in order to test the filters and figured it was more important to get the fix in and backported first.

[rhamilto]

Also could we create a follow-on story or another PR attached to this bug that adds at least a basic e2e test for the events page?

Agreed. We do have a very basic test. But I punted on adding to it since it will require figuring out how to generate additional events in order to test the filters and figured it was more important to get the fix in and backported first.

Determined I think we can safely update the existing Events test to also cover the type and text filters. Still thinking about how to test the resource filter and pause. #13407

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rhamilto: Jira Issue OCPBUGS-18401: Some pull requests linked via external trackers have merged:

• openshift/console#13395

The following pull requests linked via external trackers have not merged:

• openshift/console#13407 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-18401 has not been moved to the MODIFIED state.

In response to this:

In addition to the text filter not working, this PR also addresses:

• open websockets do not get closed when changing project or resource filter
• the type filter does not work
• pausing the stream does not work

After:

events.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202312050231.p0.g8b564f4.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

[rhamilto]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@rhamilto: new pull request created: #13413

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-12-08-202155