Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24592: Fix CI tests in helm and devconsole packages #13464

Merged

Conversation

sanketpathak
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/OCPBUGS-24592

Descriptions:

  • Fix tests in files.
    • Scenario: Deploy git workload with devfile from topology page: A-04-TC01 in frontend/packages/dev-console/integration-tests/features/e2e/add-flow-ci.feature and frontend/packages/dev-console/integration-tests/features/addFlow/create-from-devfile.feature
    • Scenario: Context menu options of helm release: HR-01-TC01 in frontend/packages/helm-plugin/integration-tests/features/helm-release.feature and frontend/packages/helm-plugin/integration-tests/features/helm/actions-on-helm-release.feature

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-24592, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-24592

Descriptions:

  • Fix tests in files.
    • Scenario: Deploy git workload with devfile from topology page: A-04-TC01 in frontend/packages/dev-console/integration-tests/features/e2e/add-flow-ci.feature and frontend/packages/dev-console/integration-tests/features/addFlow/create-from-devfile.feature
    • Scenario: Context menu options of helm release: HR-01-TC01 in frontend/packages/helm-plugin/integration-tests/features/helm-release.feature and frontend/packages/helm-plugin/integration-tests/features/helm/actions-on-helm-release.feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 21, 2023
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/helm Related to helm-plugin component/topology Related to topology approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2023
@sanketpathak
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@The-Anton
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2023
Copy link
Contributor

openshift-ci bot commented Dec 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanketpathak, The-Anton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanketpathak
Copy link
Contributor Author

PR only affects e2e tests:
/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Dec 27, 2023
@sanketpathak
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 27, 2023
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-24592, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 27, 2023

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@sanketpathak: This pull request references Jira Issue OCPBUGS-24592, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c30034 into openshift:master Dec 27, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: Jira Issue OCPBUGS-24592: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24592 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-24592

Descriptions:

  • Fix tests in files.
    • Scenario: Deploy git workload with devfile from topology page: A-04-TC01 in frontend/packages/dev-console/integration-tests/features/e2e/add-flow-ci.feature and frontend/packages/dev-console/integration-tests/features/addFlow/create-from-devfile.feature
    • Scenario: Context menu options of helm release: HR-01-TC01 in frontend/packages/helm-plugin/integration-tests/features/helm-release.feature and frontend/packages/helm-plugin/integration-tests/features/helm/actions-on-helm-release.feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202312271131.p0.g2c30034.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/helm Related to helm-plugin component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants