Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7465: Update Getting started section in Openshift UI to use expandable section #13466

Merged
merged 1 commit into from Jan 9, 2024
Merged

ODC-7465: Update Getting started section in Openshift UI to use expandable section #13466

merged 1 commit into from Jan 9, 2024

Conversation

lokanandaprabhu
Copy link
Contributor

Story: https://issues.redhat.com/browse/ODC-7465

Demo:

Screen.Recording.2023-12-21.at.12.06.11.PM.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 21, 2023 •
edited by openshift-ci bot

@lokanandaprabhu: This pull request references ODC-7465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7465

Demo:

Screen.Recording.2023-12-21.at.12.06.11.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared labels Dec 21, 2023
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Dec 21, 2023
@lokanandaprabhu
Copy link
Contributor Author

/cc @vikram-raj @jerolimov

@lokanandaprabhu
Copy link
Contributor Author

/retest

jerolimov
jerolimov suggested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lokanandaprabhu, I have also two small ideas:

frontend/packages/dev-console/src/components/add/AddPageLayout.tsx Show resolved Hide resolved
...ents/dashboard/dashboards-page/cluster-dashboard/getting-started/getting-started-section.tsx Outdated Show resolved Hide resolved
@lokanandaprabhu lokanandaprabhu force-pushed the feature/ODC-7465 branch 2 times, most recently from 7737f74 to 8baed38 Compare January 2, 2024 13:56
@lokanandaprabhu
Copy link
Contributor Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 8, 2024
jerolimov
jerolimov approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@sanketpathak
Copy link
Contributor

Verified on a cluster with admin and non-admin users
Screenshot 2024-01-08 at 5 39 40 PM

/label qe-verified

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

@sanketpathak: The label(s) /label qe-verified cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

Verified on a cluster with admin and non-admin users
Screenshot 2024-01-08 at 5 39 40 PM

/label qe-verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanketpathak
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2024 •
edited by openshift-ci bot

@lokanandaprabhu: This pull request references ODC-7465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7465

Demo:

Screen.Recording.2023-12-21.at.12.06.11.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4399622 and 2 for PR HEAD 8178523 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e7e56f1 and 1 for PR HEAD 8178523 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4f44914 and 0 for PR HEAD 8178523 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3546f35 into openshift:master Jan 9, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202401091231.p0.g3546f35.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@rawagner rawagner Awaiting requested review from rawagner

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lokanandaprabhu @openshift-ci-robot @sanketpathak @openshift-bot @jerolimov