Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster version flag check to masthead toolbar to prevent failed cluster version requests #1347

Merged
merged 1 commit into from Mar 29, 2019
Merged

Add cluster version flag check to masthead toolbar to prevent failed cluster version requests #1347

merged 1 commit into from Mar 29, 2019

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Mar 27, 2019 •
edited

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1683105

Check cluster version flag before wiring firehose to cluster version in the masthead toolbar. This prevents repetitive 403 errors in the browser js console.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2019
@openshift openshift deleted a comment from openshift-ci-robot Mar 27, 2019
@TheRealJon
Copy link
Member Author

/retest

spadgett
spadgett requested changes Mar 27, 2019
View reviewed changes
frontend/public/features.ts Outdated Show resolved Hide resolved
frontend/public/components/masthead-toolbar.jsx Outdated Show resolved Hide resolved
@TheRealJon TheRealJon changed the title Add CAN_GET_CLUSTER_VERSION to features flags Add cluster version flag check to masthead toolbar to prevent failed cluster version requests Mar 28, 2019
@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 28, 2019 •
edited

@spadget addressed your feedback

spadgett
spadgett approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TheRealJon
Copy link
Member Author

/retest

3 similar comments
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2019 •
edited

@TheRealJon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 782814c link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1278f53 into openshift:master Mar 29, 2019
@TheRealJon TheRealJon deleted the bug-1683105 branch June 26, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheRealJon @openshift-ci-robot @openshift-bot @spadgett @dtaylor113 @openshift-merge-robot