Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-26039: Make editor sidebar width consistent #13495

Merged

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jan 9, 2024

In effect, these changes divide the yaml editor view into thirds and when its sidebar is displayed, the editor has 2/3rds width and the sidebar 1/3rd width of the available content area.

fixes bug

Before
Screenshot 2024-01-09 at 6 18 16 PM
Screenshot 2024-01-09 at 6 18 07 PM


After
Screenshot 2024-01-09 at 6 15 55 PM
Screenshot 2024-01-09 at 6 16 04 PM

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-26039, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In effect, these changes divide the yaml editor view into thirds and when its sidebar is displayed, the editor has 2/3rds width and the sidebar 1/3rd width of the available content area.

fixes bug

before
Screenshot 2024-01-09 at 2 38 35 PM

after
Screenshot 2024-01-09 at 2 39 08 PM

Screenshot 2024-01-09 at 2 46 39 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared labels Jan 9, 2024
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 9, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-26039, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei January 9, 2024 19:49
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-26039, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

In effect, these changes divide the yaml editor view into thirds and when its sidebar is displayed, the editor has 2/3rds width and the sidebar 1/3rd width of the available content area.

fixes bug

before
Screenshot 2024-01-09 at 2 38 35 PM
as compared to the create Pods view

Screenshot 2024-01-09 at 2 50 54 PM

after
Screenshot 2024-01-09 at 2 39 08 PM

Screenshot 2024-01-09 at 2 46 39 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

fixes bug OCPBUGS-26039
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9d4a9b0 into openshift:master Jan 12, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: Jira Issue OCPBUGS-26039: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26039 has been moved to the MODIFIED state.

In response to this:

In effect, these changes divide the yaml editor view into thirds and when its sidebar is displayed, the editor has 2/3rds width and the sidebar 1/3rd width of the available content area.

fixes bug

Before
Screenshot 2024-01-09 at 6 18 16 PM
Screenshot 2024-01-09 at 6 18 07 PM


After
Screenshot 2024-01-09 at 6 15 55 PM
Screenshot 2024-01-09 at 6 16 04 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202401141455.p0.g9d4a9b0.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants