CONSOLE-3853: Optimize module federation of PatternFly packages #13521

vojtechszocs · 2024-01-18T20:28:54Z

Motivation

Console web application provides specific shared modules to its dynamic plugins.

Most of these shared modules are configured as follows:

only a single version of the module can be loaded at runtime (singleton: true)
plugins will not bundle their own fallback (i.e. build-time) version of the module (allowFallback: false)

While this configuration favors code consistency, it's not flexible enough for PatternFly packages.

Starting with 4.15 release, all PatternFly v4 shared modules are configured as singleton: false and allowFallback: true (#12983). This allows existing plugins using these PatternFly v4 shared modules to work as expected. At some point in future, these PatternFly v4 shared modules will be deprecated and eventually removed.

In order to share PatternFly v5+ modules in an optimal way, this PR implements the concept of shared dynamic modules.

Dynamic Modules

Some vendor packages may support dynamic modules to be used with webpack module federation.

Taking @patternfly/react-core package as an example, it includes a dist/dynamic directory containing package.json files that refer to specific modules of that package.

For example, all Alert component related code and types (including exports like Alert, AlertProps, AlertContext etc.) have a corresponding dynamic module at @patternfly/react-core/dist/dynamic/components/Alert/package.json

{
  "name": "@patternfly/react-core-alert-dynamic",
  "main": "../../../js/components/Alert/index.js", // => dist/js/components/Alert/index.js
  "module": "../../../esm/components/Alert/index.js", // => dist/esm/components/Alert/index.js
  "typings": "../../../esm/components/Alert/index.d.ts", // => dist/esm/components/Alert/index.d.ts
  "version": "5.1.1",
  "private": true
}

In the plugin code, this dynamic module can then be imported like so:

import { Alert, AlertProps, AlertContext } from '@patternfly/react-core/dist/dynamic/components/Alert';

Let's say the plugin also uses some other PatternFly components:

import { Wizard, WizardProps } from '@patternfly/react-core/dist/dynamic/components/Wizard';

Once we configure webpack module federation to treat each of these dynamic modules as shared modules like so:

// see packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts

new DynamicRemotePlugin({
  // ...
  sharedModules: {
    // ...
    '@patternfly/react-core/dist/dynamic/components/Alert': { version: '5.1.1', requiredVersion: '5.1.1' },
    '@patternfly/react-core/dist/dynamic/components/Wizard': { version: '5.1.1', requiredVersion: '5.1.1' },
  },
  // ...
});

this will effectively allow us to load the same Alert or Wizard dynamic module once or multiple times in different versions.

Example use case

Plugin A uses @patternfly/react-core 5.1.1 - using Alert and Wizard
- Alert dynamic module [5.1.1] does not exist in shared scope ➡️ add to shared scope
- Wizard dynamic module [5.1.1] does not exist in shared scope ➡️ add to shared scope
Plugin B uses @patternfly/react-core 5.1.1 - using only Wizard
- Wizard dynamic module [5.1.1] exists in shared scope ➡️ reuse the one in shared scope
Plugin C uses @patternfly/react-core 5.2.0 - using only Alert
- Alert dynamic module [5.2.0] does not exist in shared scope ➡️ add to shared scope

Dynamic module processing

This PR includes a parser (getDynamicModuleMap) that detects all dynamic modules of the given vendor package.

The default list of vendor packages for which dynamic modules should be processed is:

@patternfly/react-core
@patternfly/react-icons

This list can be customized via new ConsoleRemotePlugin option sharedDynamicModuleSettings.

ConsoleRemotePlugin has been modified to perform the following tasks:

✔️ automatically detect all dynamic modules and register them with webpack as shared modules
✔️ automatically transform imports within the plugin code to utilize dynamic modules whenever possible

Impact on existing plugins

This PR attempts to be as backwards compatible as possible and provide reasonable defaults for all dynamic plugins.

Here is the list of checks and minor changes that plugins should address:

@openshift-console/dynamic-plugin-sdk-webpack now has a peer dependency "typescript": ">=4.5.5"
- ❗ make sure your project has a typescript (dev) dependency that matches the above range
- 📝 this is due to webpack dynamicModuleImportLoader using TypeScript compiler API to transform code
make sure your project has explicit @patternfly/react-core and @patternfly/react-icons (dev) dependencies
- 📝 otherwise, you may get webpack warnings about being unable to detect required version of dynamic modules
avoid non-index imports for @patternfly/react-core and @patternfly/react-icons packages
- 📝 webpack dynamicModuleImportLoader will warn you about any non-index imports detected in your code

// do _not_ do this:
import { MonitoringIcon } from '@patternfly/react-icons/dist/esm/icons/monitoring-icon';
// instead, do this:
import { MonitoringIcon } from '@patternfly/react-icons';

Smoke test verification

dynamic demo plugin can be built without any errors or warnings
dynamic demo plugin loads and works in Console as before
in development build of Console, inspect webpackSharedScope object

openshift-ci-robot · 2024-01-18T20:28:58Z

@vojtechszocs: This pull request references CONSOLE-3853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Motivation

Console web application provides specific shared modules to its dynamic plugins.

Most of these shared modules are configured as follows:

only a single version of the module can be loaded at runtime (singleton: true)

plugins will not bundle their own fallback (i.e. build-time) version of the module (allowFallback: false)

While this configuration favors code consistency, it's not flexible enough for PatternFly packages.

Starting with 4.15 release, all PatternFly v4 shared modules are configured as singleton: false and allowFallback: true (#12983). This allows existing plugins using these PatternFly v4 shared modules to work as expected. At some point in future, these PatternFly v4 shared modules will be deprecated and eventually removed.

In order to share PatternFly v5+ modules in an optimal way, this PR implements the concept of shared dynamic modules.

Dynamic Modules

Some vendor packages may support dynamic modules to be used with webpack module federation.

Taking @patternfly/react-core package as an example, it includes a dist/dynamic directory containing package.json files that refer to specific modules of that package.

For example, all Alert component related code and types (including exports like Alert, AlertProps, AlertContext etc.) have a corresponding dynamic module at @patternfly/react-core/dist/dynamic/components/Alert/package.json
{
 "name": "@patternfly/react-core-alert-dynamic",
 "main": "../../../js/components/Alert/index.js", // => dist/js/components/Alert/index.js
 "module": "../../../esm/components/Alert/index.js", // => dist/esm/components/Alert/index.js
 "typings": "../../../esm/components/Alert/index.d.ts", // => dist/esm/components/Alert/index.d.ts
 "version": "5.1.1",
 "private": true
}
In the plugin code, this dynamic module can then be imported like so:
import { Alert, AlertProps, AlertContext } from '@patternfly/react-core/dist/dynamic/components/Alert';
Let's say the plugin also uses some other PatternFly components:
import { Wizard, WizardProps } from '@patternfly/react-core/dist/dynamic/components/Wizard';
Once we configure webpack module federation to treat each of these dynamic modules as shared modules like so:
// see packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts

new DynamicRemotePlugin({
 // ...
 sharedModules: {
   // ...
   '@patternfly/react-core/dist/dynamic/components/Alert': { version: '5.1.1', requiredVersion: '5.1.1' },
   '@patternfly/react-core/dist/dynamic/components/Wizard': { version: '5.1.1', requiredVersion: '5.1.1' },
 },
 // ...
});
this will effectively allow us to load the same Alert or Wizard dynamic module once or multiple times in different versions.

Example use case

Plugin A uses @patternfly/react-core 5.1.1 - using Alert and Wizard

Alert dynamic module [5.1.1] does not exist in shared scope ➡️ add to shared scope

Wizard dynamic module [5.1.1] does not exist in shared scope ➡️ add to shared scope

Plugin B uses @patternfly/react-core 5.1.1 - using only Wizard

Wizard dynamic module [5.1.1] exists in shared scope ➡️ reuse the one in shared scope

Plugin C uses @patternfly/react-core 5.2.0 - using only Alert

Alert dynamic module [5.2.0] does not exist in shared scope ➡️ add to shared scope

Dynamic module processing

This PR includes a parser (getDynamicModuleMap) that detects all dynamic modules of the given vendor package.

The default list of vendor packages for which dynamic modules should be processed is:

@patternfly/react-core

@patternfly/react-icons

This list can be customized via new ConsoleRemotePlugin option sharedDynamicModuleSettings.

ConsoleRemotePlugin has been modified to perform the following tasks:

✔️ automatically detect all dynamic modules and register them with webpack as shared modules

✔️ automatically transform imports within the plugin code to utilize dynamic modules whenever possible

Impact on existing plugins

This PR attempts to be as backwards compatible as possible and provide reasonable defaults for all dynamic plugins.

Here is the list of checks and minor changes that plugins should address:

@openshift-console/dynamic-plugin-sdk-webpack now has a peer dependency "typescript": ">=4.5.5"

❗ make sure your project has a typescript (dev) dependency that matches the above range

📝 this is due to webpack dynamicModuleImportLoader using TypeScript compiler API to transform code

make sure your project has explicit @patternfly/react-core and @patternfly/react-icons (dev) dependencies

📝 otherwise, you may get webpack warnings about being unable to detect required version of dynamic modules

avoid non-index imports for @patternfly/react-core and @patternfly/react-icons packages

📝 webpack dynamicModuleImportLoader will warn you about any non-index imports detected in your code
// do _not_ do this:
import { MonitoringIcon } from '@patternfly/react-icons/dist/esm/icons/monitoring-icon';
// instead, do this:
import { MonitoringIcon } from '@patternfly/react-icons';
Smoke test verification

dynamic demo plugin can be built without any errors or warnings

dynamic demo plugin loads and works in Console as before

in development build of Console, inspect webpackSharedScope object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2024-01-18T20:54:06Z

frontend/packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts

+          );
+
+          if (!modifiedModules.includes(moduleRequest) && transformImports(moduleRequest)) {
+            normalModule.loaders.push({


This is where our custom loader gets registered for modules that match the transformImports filter.

webpack loaders are applied in reverse order, so the last one runs first.

This code was inspired by https://github.com/artembatura/modify-source-webpack-plugin

vojtechszocs · 2024-01-19T16:40:39Z

/retest

spadgett

Nice work on this 👍 No major concerns from me. I'll give @jhadvig and others a chance to review.

/approve

spadgett · 2024-01-19T18:07:41Z

dynamic-demo-plugin/src/components/ClusterOverview/Inventory.tsx

-import { MonitoringIcon } from '@patternfly/react-icons/dist/esm/icons/monitoring-icon';
+import { MonitoringIcon } from '@patternfly/react-icons';


We'll make sure we document the recommended way to do these imports.

@spadgett @jhadvig The dynamic plugin README is already quite big.

I think it makes sense to add a separate Markdown doc to document Console plugin shared modules, including PatternFly dynamic modules. What do you think?

So I think it would be best to keep it tin the dynamic plugin README, even if its will make it bigger.

OK, will update the README.

spadgett · 2024-01-19T18:09:45Z

frontend/packages/console-dynamic-plugin-sdk/src/utils/dynamic-module-parser.ts

+  const dynamicModulePathToPkgDir = glob
+    .sync(`${basePath}/dist/dynamic/**/package.json`)
+    .reduce<Record<string, string>>((acc, pkgFile) => {
+      // eslint-disable-next-line


nitpick: better to only disable the eslint rule we need

@spadgett The require call (line below) actually triggers multiple ESLint errors:

72:19 error Calls to require() should use string literals import/no-dynamic-require 72:19 error Unexpected require() global-require 72:19 error A `require()` style import is forbidden @typescript-eslint/no-require-imports 72:19 error Require statement not part of import statement @typescript-eslint/no-var-requires

so I didn't specify the rule names explicitly. Such require calls always tend to trigger a lot of ESLint errors.

Is it OK to leave it like so for simplicity?

We do this also in some other parts of the codebase, e.g. packages/console-dynamic-plugin-sdk/src/runtime/plugin-manifest.ts

+1 leaving as is

spadgett · 2024-01-19T18:16:39Z

...onsole-dynamic-plugin-sdk/src/webpack/loaders/__tests__/dynamic-module-import-loader.spec.ts

Thank you for adding the tests 👍

rhamilto · 2024-01-22T19:09:34Z

/lgtm

QE Approver:
/assign @yapei
Docs Approver:
/assign @opayne1
PX Approver:
/assign @RickJWagner

RickJWagner · 2024-01-22T19:29:17Z

/label px-approved

jhadvig

🤯 🤯 🤯
Awesome work @vojtechszocs Looking forward for the demo 🙌
/lgtm

jhadvig · 2024-01-22T20:06:22Z

dynamic-demo-plugin/src/components/ClusterOverview/Inventory.tsx

-import { MonitoringIcon } from '@patternfly/react-icons/dist/esm/icons/monitoring-icon';
+import { MonitoringIcon } from '@patternfly/react-icons';


So I think it would be best to keep it tin the dynamic plugin README, even if its will make it bigger.

jhadvig · 2024-01-22T20:37:55Z

/retest

opayne1 · 2024-01-22T21:16:19Z

/label docs-approved

jhadvig · 2024-01-23T13:07:13Z

adding labels manually since they are not picked up by the bot

jhadvig · 2024-01-24T08:11:02Z

/retest

vojtechszocs · 2024-01-29T17:42:30Z

dynamic-demo-plugin/tsconfig.json

@@ -11,5 +11,12 @@
    "skipLibCheck": true,
    "lib": ["dom", "es7", "es2017.string"]
  },
-  "include": ["src"]
+  "include": ["src"],
+  "ts-node": {


This makes debugging the Console webpack code (triggered via demo plugin webpack build) much easier, paired with the following VS Code launch config:

{ "name": "Example", "type": "node", "request": "launch", "runtimeExecutable": "node", "runtimeArgs": ["--nolazy", "-r", "ts-node/register/transpile-only"], "args": ["node_modules/.bin/webpack"], "cwd": "${workspaceRoot}", "internalConsoleOptions": "openOnSessionStart", "skipFiles": ["<node_internals>/**"] }

jhadvig

/lgtm

openshift-ci · 2024-01-30T08:15:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto, spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhadvig,rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

XiyunZhao · 2024-01-30T11:52:57Z

The dynamic demo plugin could be loaded without any issue, all plugin fictional is work as normal, no new CSS issue found
For the local development, the plugin can be built without any errors, and the information of 'webpackSharedScope' object is correct.
/label qe-approved

openshift-ci-robot · 2024-01-30T11:53:02Z

@vojtechszocs: This pull request references CONSOLE-3853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Motivation

Console web application provides specific shared modules to its dynamic plugins.

Most of these shared modules are configured as follows:

only a single version of the module can be loaded at runtime (singleton: true)

plugins will not bundle their own fallback (i.e. build-time) version of the module (allowFallback: false)

While this configuration favors code consistency, it's not flexible enough for PatternFly packages.

Starting with 4.15 release, all PatternFly v4 shared modules are configured as singleton: false and allowFallback: true (#12983). This allows existing plugins using these PatternFly v4 shared modules to work as expected. At some point in future, these PatternFly v4 shared modules will be deprecated and eventually removed.

In order to share PatternFly v5+ modules in an optimal way, this PR implements the concept of shared dynamic modules.

Dynamic Modules

Some vendor packages may support dynamic modules to be used with webpack module federation.

Taking @patternfly/react-core package as an example, it includes a dist/dynamic directory containing package.json files that refer to specific modules of that package.

For example, all Alert component related code and types (including exports like Alert, AlertProps, AlertContext etc.) have a corresponding dynamic module at @patternfly/react-core/dist/dynamic/components/Alert/package.json
{
 "name": "@patternfly/react-core-alert-dynamic",
 "main": "../../../js/components/Alert/index.js", // => dist/js/components/Alert/index.js
 "module": "../../../esm/components/Alert/index.js", // => dist/esm/components/Alert/index.js
 "typings": "../../../esm/components/Alert/index.d.ts", // => dist/esm/components/Alert/index.d.ts
 "version": "5.1.1",
 "private": true
}
In the plugin code, this dynamic module can then be imported like so:
import { Alert, AlertProps, AlertContext } from '@patternfly/react-core/dist/dynamic/components/Alert';
Let's say the plugin also uses some other PatternFly components:
import { Wizard, WizardProps } from '@patternfly/react-core/dist/dynamic/components/Wizard';
Once we configure webpack module federation to treat each of these dynamic modules as shared modules like so:
// see packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts

new DynamicRemotePlugin({
 // ...
 sharedModules: {
   // ...
   '@patternfly/react-core/dist/dynamic/components/Alert': { version: '5.1.1', requiredVersion: '5.1.1' },
   '@patternfly/react-core/dist/dynamic/components/Wizard': { version: '5.1.1', requiredVersion: '5.1.1' },
 },
 // ...
});
this will effectively allow us to load the same Alert or Wizard dynamic module once or multiple times in different versions.

Example use case

Plugin A uses @patternfly/react-core 5.1.1 - using Alert and Wizard

Alert dynamic module [5.1.1] does not exist in shared scope ➡️ add to shared scope

Wizard dynamic module [5.1.1] does not exist in shared scope ➡️ add to shared scope

Plugin B uses @patternfly/react-core 5.1.1 - using only Wizard

Wizard dynamic module [5.1.1] exists in shared scope ➡️ reuse the one in shared scope

Plugin C uses @patternfly/react-core 5.2.0 - using only Alert

Alert dynamic module [5.2.0] does not exist in shared scope ➡️ add to shared scope

Dynamic module processing

This PR includes a parser (getDynamicModuleMap) that detects all dynamic modules of the given vendor package.

The default list of vendor packages for which dynamic modules should be processed is:

@patternfly/react-core

@patternfly/react-icons

This list can be customized via new ConsoleRemotePlugin option sharedDynamicModuleSettings.

ConsoleRemotePlugin has been modified to perform the following tasks:

✔️ automatically detect all dynamic modules and register them with webpack as shared modules

✔️ automatically transform imports within the plugin code to utilize dynamic modules whenever possible

Impact on existing plugins

This PR attempts to be as backwards compatible as possible and provide reasonable defaults for all dynamic plugins.

Here is the list of checks and minor changes that plugins should address:

@openshift-console/dynamic-plugin-sdk-webpack now has a peer dependency "typescript": ">=4.5.5"

❗ make sure your project has a typescript (dev) dependency that matches the above range

📝 this is due to webpack dynamicModuleImportLoader using TypeScript compiler API to transform code

make sure your project has explicit @patternfly/react-core and @patternfly/react-icons (dev) dependencies

📝 otherwise, you may get webpack warnings about being unable to detect required version of dynamic modules

avoid non-index imports for @patternfly/react-core and @patternfly/react-icons packages

📝 webpack dynamicModuleImportLoader will warn you about any non-index imports detected in your code
// do _not_ do this:
import { MonitoringIcon } from '@patternfly/react-icons/dist/esm/icons/monitoring-icon';
// instead, do this:
import { MonitoringIcon } from '@patternfly/react-icons';
Smoke test verification

dynamic demo plugin can be built without any errors or warnings

dynamic demo plugin loads and works in Console as before

in development build of Console, inspect webpackSharedScope object

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2024-01-30T16:46:39Z

This PR addresses the following item of CONSOLE-3883 (Improve Console dynamic plugin documentation)

improve docs on shared modules (CONSOLE-3328)

jhadvig · 2024-01-31T12:41:24Z

/label acknowledge-critical-fixes-only

openshift-ci-robot · 2024-01-31T16:28:21Z

/retest-required

Remaining retests: 0 against base HEAD 4f8fa7b and 2 for PR HEAD 6c9b2ea in total

openshift-ci-robot · 2024-01-31T23:47:46Z

/retest-required

Remaining retests: 0 against base HEAD aa09f42 and 1 for PR HEAD 6c9b2ea in total

openshift-ci-robot · 2024-02-01T03:46:22Z

/retest-required

Remaining retests: 0 against base HEAD 6935c3f and 0 for PR HEAD 6c9b2ea in total

openshift-ci-robot · 2024-02-01T08:37:27Z

/hold

Revision 6c9b2ea was retested 3 times: holding

rhamilto · 2024-02-01T15:54:17Z

/retest

jhadvig · 2024-02-01T16:37:25Z

/cherry-pick release-4.15

openshift-cherrypick-robot · 2024-02-01T16:37:28Z

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vojtechszocs · 2024-02-01T17:17:47Z

/hold cancel

openshift-ci-robot · 2024-02-01T17:40:27Z

/retest-required

Remaining retests: 0 against base HEAD 6935c3f and 2 for PR HEAD 6c9b2ea in total

vojtechszocs · 2024-02-01T17:51:47Z

/retest

openshift-ci-robot · 2024-02-02T02:01:17Z

/retest-required

Remaining retests: 0 against base HEAD 97b8914 and 1 for PR HEAD 6c9b2ea in total

jhadvig · 2024-02-02T08:50:03Z

/retest

openshift-ci · 2024-02-02T13:09:20Z

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-cherrypick-robot · 2024-02-02T13:14:20Z

@jhadvig: #13521 failed to apply on top of branch "release-4.15":

Applying: Optimize module federation of PatternFly packages
Using index info to reconstruct a base tree...
M	dynamic-demo-plugin/yarn.lock
M	frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts
M	frontend/packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts
CONFLICT (content): Merge conflict in frontend/packages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts
Auto-merging frontend/packages/console-dynamic-plugin-sdk/scripts/package-definitions.ts
Auto-merging dynamic-demo-plugin/yarn.lock
Removing dynamic-demo-plugin/.gitignore
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Optimize module federation of PatternFly packages
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-02T18:43:46Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202402021641.p0.g74c31e3.assembly.stream for distgit openshift-enterprise-console.
All builds following this will include this PR.

Since openshift/console#13521 merged, plugins are expected to have an explicit @patternfly/react-icons dependency.

Optimize module federation of PatternFly packages

0188604

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024

openshift-ci bot requested review from jcaianirh and jhadvig January 18, 2024 20:29

openshift-ci bot added the component/sdk Related to console-plugin-sdk label Jan 18, 2024

Expose webpack shared scope object in non-production builds

2bf56da

vojtechszocs commented Jan 18, 2024

View reviewed changes

spadgett approved these changes Jan 19, 2024

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024

openshift-ci bot assigned opayne1, RickJWagner and yapei Jan 22, 2024

RickJWagner removed their assignment Jan 22, 2024

jhadvig approved these changes Jan 22, 2024

View reviewed changes

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 22, 2024

jhadvig added lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR labels Jan 23, 2024

vojtechszocs mentioned this pull request Jan 26, 2024

Generate dist/dynamic-modules.json for relevant packages patternfly/patternfly-react#10046

Merged

Address review comments

6c9b2ea

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024

vojtechszocs commented Jan 29, 2024

View reviewed changes

jhadvig approved these changes Jan 30, 2024

View reviewed changes

openshift-ci bot assigned jhadvig Jan 30, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 30, 2024

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 31, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024

vojtechszocs mentioned this pull request Feb 1, 2024

OCPBUGS-28917: Optimize federation of shared PF5 code for dynamic plugins #13566

Merged

openshift-merge-bot bot merged commit 74c31e3 into openshift:master Feb 2, 2024
6 checks passed

kyoto added a commit to kyoto/lightspeed-console that referenced this pull request Feb 5, 2024

Add @patternfly/react-icons to package.json

0650e4f

Since openshift/console#13521 merged, plugins are expected to have an explicit @patternfly/react-icons dependency.

kyoto mentioned this pull request Feb 5, 2024

Add @patternfly/react-icons to package.json openshift/lightspeed-console#5

Merged

		import { MonitoringIcon } from '@patternfly/react-icons/dist/esm/icons/monitoring-icon';
		import { MonitoringIcon } from '@patternfly/react-icons';

CONSOLE-3853: Optimize module federation of PatternFly packages #13521

CONSOLE-3853: Optimize module federation of PatternFly packages #13521

Conversation

vojtechszocs commented Jan 18, 2024

Motivation

Dynamic Modules

Example use case

Dynamic module processing

Impact on existing plugins

Smoke test verification

openshift-ci-robot commented Jan 18, 2024 • edited by openshift-ci bot

Motivation

Dynamic Modules

Example use case

Dynamic module processing

Impact on existing plugins

Smoke test verification

vojtechszocs Jan 18, 2024 • edited

Choose a reason for hiding this comment

vojtechszocs commented Jan 19, 2024

spadgett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhamilto commented Jan 22, 2024

RickJWagner commented Jan 22, 2024

jhadvig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhadvig commented Jan 22, 2024

opayne1 commented Jan 22, 2024

jhadvig commented Jan 23, 2024

jhadvig commented Jan 24, 2024

Choose a reason for hiding this comment

jhadvig left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 30, 2024

XiyunZhao commented Jan 30, 2024

openshift-ci-robot commented Jan 30, 2024 • edited by openshift-ci bot

Motivation

Dynamic Modules

Example use case

Dynamic module processing

Impact on existing plugins

Smoke test verification

vojtechszocs commented Jan 30, 2024 • edited

jhadvig commented Jan 31, 2024

openshift-ci-robot commented Jan 31, 2024

openshift-ci-robot commented Jan 31, 2024

openshift-ci-robot commented Feb 1, 2024

openshift-ci-robot commented Feb 1, 2024

rhamilto commented Feb 1, 2024

jhadvig commented Feb 1, 2024

openshift-cherrypick-robot commented Feb 1, 2024

vojtechszocs commented Feb 1, 2024

openshift-ci-robot commented Feb 1, 2024

vojtechszocs commented Feb 1, 2024

openshift-ci-robot commented Feb 2, 2024

jhadvig commented Feb 2, 2024

openshift-ci bot commented Feb 2, 2024

openshift-cherrypick-robot commented Feb 2, 2024

openshift-bot commented Feb 2, 2024

openshift-ci-robot commented Jan 18, 2024 •

edited by openshift-ci bot

vojtechszocs Jan 18, 2024 •

edited

openshift-ci-robot commented Jan 30, 2024 •

edited by openshift-ci bot

vojtechszocs commented Jan 30, 2024 •

edited