Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-28383: Activity card event has expanded content that is not correctly left aligned with the rest of the card content #13547

Merged
merged 1 commit into from Feb 7, 2024
Merged

OCPBUGS-28383: Activity card event has expanded content that is not correctly left aligned with the rest of the card content #13547

merged 1 commit into from Feb 7, 2024

Conversation

sg00dwin
Copy link
Member

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Jira Issue OCPBUGS-28383, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-28383

before

Screenshot 2024-01-26 at 3 55 39 PM

after
Screenshot 2024-01-26 at 4 03 12 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei January 26, 2024 21:10
@sg00dwin sg00dwin changed the title OCPBUGS-28383: Activity card event has expanded content that is not correctly aligned with the rest of the card content OCPBUGS-28383: Activity card event has expanded content that is not correctly left aligned with the rest of the card content Jan 26, 2024
@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/shared Related to console-shared labels Jan 26, 2024
@rhamilto
Copy link
Member

/retest

1 similar comment
@rhamilto
Copy link
Member

/retest

rhamilto
rhamilto reviewed Jan 30, 2024
View reviewed changes
frontend/packages/console-shared/src/components/dashboard/activity-card/activity-card.scss Outdated
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: errant whitespace

rhamilto
rhamilto approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1e4de7a and 2 for PR HEAD bf6ea26 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 13f3942 and 1 for PR HEAD bf6ea26 in total

@rhamilto
Copy link
Member

rhamilto commented Feb 6, 2024

/retest

1 similar comment
@rhamilto
Copy link
Member

rhamilto commented Feb 6, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 829d4fd and 0 for PR HEAD bf6ea26 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 210175b into openshift:master Feb 7, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: Jira Issue OCPBUGS-28383: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28383 has been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-28383

before

Screenshot 2024-01-26 at 3 55 39 PM

after
Screenshot 2024-01-26 at 4 03 12 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202402071412.p0.g210175b.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@yapei yapei Awaiting requested review from yapei

@rawagner rawagner Awaiting requested review from rawagner

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dashboard Related to dashboard component/shared Related to console-shared jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sg00dwin @openshift-ci-robot @rhamilto @openshift-bot