RHSTOR-4130: Cross storage class clone /restore

[TimothyAsirJeyasing]

This patch provides the following feature:

1. Storage Class Selection:
   Users can now choose a storage class from the same provider when cloning or restoring.
   This flexibility allows seamless transitions between storage classes with different replica counts (e.g., moving from SC with 3 replicas to 2/1 replicas).
2. Managed Service Improvement:
   Managed services can now clone Persistent Volumes (PVs) from slow to fast storage classes.
   This enhancement ensures efficient data movement and optimisation.
   Epic link: https://issues.redhat.com/browse/RHSTOR-4130

[openshift-ci]

Hi @TimothyAsirJeyasing. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TimothyAsirJeyasing]

[TimothyAsirJeyasing]

@SanjalKatiyar Please review

[SanjalKatiyar]

/ok-to-test

[SanjalKatiyar]

please check how restore-pvc-modal.tsx is implemented... changes are not correct right now...

[GowthamShanmugam]

please check how restore-pvc-modal.tsx is implemented... changes are not correct right now...

Ya, just now I noticed, restore-pvc-modal.tsx has a better implementation, cc: @TimothyAsirJeyasing please check

[TimothyAsirJeyasing]

[SanjalKatiyar]

please check how restore-pvc-modal.tsx is implemented... changes are not correct right now...

this is still missing, create button is not disabled (for cases where it should be)...

[SanjalKatiyar]

if "clone" modal is filtering based on same provisioner + encrypted SC, then same filtering should be added for "restore" modal too...

[TimothyAsirJeyasing]

For restore modal, there is no option available about encryption for snapshot class resource of VolumeSnapshotClass kind. We need the operator to provide this.

[SanjalKatiyar]

For restore modal, there is no option available about encryption for snapshot class resource of VolumeSnapshotClass kind. We need the operator to provide this.

not really, don't you know which StorageClass was used for creating the snapshot ?? Once you know that, you can simply check if that StorageClass and new selected ones are both encrypted or not...
but before that you need to ensure this: #13549 (comment)

[TimothyAsirJeyasing]

[TimothyAsirJeyasing]

[TimothyAsirJeyasing]

/retest

[TimothyAsirJeyasing]

/test e2e-gcp-console
/test frontend

[TimothyAsirJeyasing]

@jhadvig please have a look

[jhadvig]

/lgtm
/approve

Thanks @TimothyAsirJeyasing for this PR :)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cyril-ui-developer]

QE Approver:
/assign @yapei
Docs Approver:
/assign @opayne1
PX Approver:
/assign @RickJWagner

[RickJWagner]

Thank you for providing the screen snapshots, they are very useful for reviews.

/label px-approved

[SanjalKatiyar]

QE Approver: /assign @yapei Docs Approver: /assign @opayne1 PX Approver: /assign @RickJWagner

@yapei @opayne1 can you guys please take a look and add labels if that's alright ?

[yapei]

/label qe-approved

[openshift-ci-robot]

@TimothyAsirJeyasing: This pull request references RHSTOR-4130 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

This patch provides the following feature:

1. Storage Class Selection:
   Users can now choose a storage class from the same provider when cloning or restoring.
   This flexibility allows seamless transitions between storage classes with different replica counts (e.g., moving from SC with 3 replicas to 2/1 replicas).
2. Managed Service Improvement:
   Managed services can now clone Persistent Volumes (PVs) from slow to fast storage classes.
   This enhancement ensures efficient data movement and optimisation.
   Epic link: https://issues.redhat.com/browse/RHSTOR-4130

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[opayne1]

/label docs-approved

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d6e2e1e and 2 for PR HEAD 58c5ff4 in total

[TimothyAsirJeyasing]

/test e2e-gcp-console

[TimothyAsirJeyasing]

/test e2e-gcp-console

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD f968847 and 1 for PR HEAD 58c5ff4 in total

[SanjalKatiyar]

/test e2e-gcp-console

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 13aeba4 and 0 for PR HEAD 58c5ff4 in total