New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-3921: Remove Disks/NICs page from Node details #13552
CONSOLE-3921: Remove Disks/NICs page from Node details #13552
Conversation
@rawagner: This pull request references CONSOLE-3921 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label acknowledge-critical-fixes-only
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rawagner: This pull request references CONSOLE-3921 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
QE Approver: |
/label docs-approved |
/label px-approved |
Checked on the ipi-on-bm cluster launched against the pr code, now the "Network Interfaces" and "Disks" tabs will be removed from node page and kept on BMH page. |
@rawagner: This pull request references CONSOLE-3921 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
164d5cf
into
openshift:master
The PR only removes two tabs from Node details page. These tabs are duplicates of existing tabs of BareMetalHost details.