New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-28746: fix bug where Expand PVC modal assumes pvc.spec.resou… #13558
[release-4.14] OCPBUGS-28746: fix bug where Expand PVC modal assumes pvc.spec.resou… #13558
Conversation
…ces.requests.storage value includes a unit
@openshift-cherrypick-robot: Jira Issue OCPBUGS-27909 has been cloned as Jira Issue OCPBUGS-28746. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
Checked on cluster launched against the pr, create pvc with spec.requests.storage: "2147483648", check on pvc details page, the "Requested capacity" is 2 GiB. Check on "Expand PVC" modal, it shows 2 GiB. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28746. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@rhamilto: This pull request references Jira Issue OCPBUGS-28746, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest @yapei, mind reviewing and adding approval? |
I see |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, rhamilto, yapei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
I completely overlooked those labels. Sorry, @yapei! Thank you for retesting! |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e50f3d4
into
openshift:release-4.14
@openshift-cherrypick-robot: Jira Issue OCPBUGS-28746: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28746 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.14.0-202404021308.p0.ge50f3d4.assembly.stream.el8 for distgit openshift-enterprise-console. |
Fix included in accepted release 4.14.0-0.nightly-2024-04-02-185046 |
This is an automated cherry-pick of #13542
/assign rhamilto