Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenID IDP form #1356

Merged
merged 1 commit into from Mar 29, 2019
Merged

Update OpenID IDP form #1356

merged 1 commit into from Mar 29, 2019

Conversation

spadgett
Copy link
Member

  • Make Client Secret a password field instead of file upload
  • Prefill default claim values
  • Add form help text

/assign @jcaianirh
@enj fyi

Add Identity Provider: OpenID Connect · OKD 2019-03-28 14-50-56

@spadgett
Update OpenID IDP form
699485e 
* Make Client Secret a password field instead of file upload
* Prefill default claim values
* Add form help text
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2019
jcaianirh
jcaianirh requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett probably best to be consistent with the changes between htpasswd and openid connect

jcaianirh
jcaianirh approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @spadgett !

@jcaianirh
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5bd3a43 into openshift:master Mar 29, 2019
@spadgett spadgett deleted the openid-tweaks branch March 29, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jcaianirh jcaianirh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @jcaianirh @openshift-ci-robot @openshift-merge-robot