Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3922: Convert legacy ListPage to dynamic-plugin-sdk ListPage- components in Console VolumeSnapshots Storage #13560

Merged
merged 1 commit into from Mar 14, 2024
Merged

CONSOLE-3922: Convert legacy ListPage to dynamic-plugin-sdk ListPage- components in Console VolumeSnapshots Storage #13560

merged 1 commit into from Mar 14, 2024
+401 −211

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented Jan 31, 2024 •
edited

This change does not impact the UI screens but improve the code quality.
However the QA should verify the UI screens with the current ones.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 31, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3922 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jan 31, 2024
@cyril-ui-developer cyril-ui-developer changed the title [NOT-READY-REVIEW]CONSOLE-3922: Convert legacy ListPage to dynamic-plugin-sdk ListPage- components in Console VolumeSnapshots Storage [WIP]CONSOLE-3922: Convert legacy ListPage to dynamic-plugin-sdk ListPage- components in Console VolumeSnapshots Storage Feb 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@cyril-ui-developer cyril-ui-developer force-pushed the pvc-volsnapshot-row-filter-refactor branch 3 times, most recently from 3dee921 to f891f7c Compare February 14, 2024 13:25
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Feb 14, 2024
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer cyril-ui-developer force-pushed the pvc-volsnapshot-row-filter-refactor branch 2 times, most recently from 291c797 to 95adeb4 Compare February 22, 2024 19:10
@cyril-ui-developer cyril-ui-developer changed the title [WIP]CONSOLE-3922: Convert legacy ListPage to dynamic-plugin-sdk ListPage- components in Console VolumeSnapshots Storage CONSOLE-3922: Convert legacy ListPage to dynamic-plugin-sdk ListPage- components in Console VolumeSnapshots Storage Feb 22, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@cyril-ui-developer
Copy link
Contributor Author

/retest

2 similar comments
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3922 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This change does not impact the UI screens but improve the code quality.
However the QA should verify the the UI screens with the current ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3922 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This change does not impact the UI screens but improve the code quality.
However the QA should verify the UI screens with the current ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sg00dwin
sg00dwin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@cyril-ui-developer
Copy link
Contributor Author

/retest

3 similar comments
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@cyril-ui-developer
Copy link
Contributor Author

This work is tech debt and no changes to UI screens.
QE Approver:
/assign @yapei @yanpzhan

@XiyunZhao
Copy link

This PR has been tested by using regression testing, no issue was found
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3922 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This change does not impact the UI screens but improve the code quality.
However the QA should verify the UI screens with the current ones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member

rhamilto commented Mar 7, 2024

Adding labels as this is tech debt
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 7, 2024
@cyril-ui-developer
Copy link
Contributor Author

Adding labels as this is tech debt /label docs-approved /label px-approved

@rhamilto Thank you.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7bfcdc2 and 2 for PR HEAD f114037 in total

@rhamilto
Copy link
Member

rhamilto commented Mar 7, 2024

/retest

2 similar comments
@jcaianirh
Copy link
Member

/retest

@cyril-ui-developer
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 77d383d and 1 for PR HEAD f114037 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 03cecd0 and 0 for PR HEAD f114037 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision f114037 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@cyril-ui-developer
Copy link
Contributor Author

/retest

@cyril-ui-developer
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 824a736 and 2 for PR HEAD f114037 in total

@cyril-ui-developer
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1ff7e80 into openshift:master Mar 14, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202403141746.p0.g1ff7e80.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@sg00dwin sg00dwin sg00dwin approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

@sg00dwin sg00dwin

@yanpzhan yanpzhan

@yapei yapei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cyril-ui-developer @openshift-ci-robot @rhamilto @XiyunZhao @jcaianirh @openshift-bot @sg00dwin @yanpzhan @yapei