New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] AUTH-440: OIDC: refresh sessions with a refresh token if present #13563
[release-4.15] AUTH-440: OIDC: refresh sessions with a refresh token if present #13563
Conversation
@stlaz: This pull request references AUTH-440 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Make it possible for multiple sessions to exist in parallel across all the instances of the console. This is achieved by naming the session cookies after the pod that create them. That means that if there's a new rollout, a new cookie will be created if browser traffic is redirected to a new console instance. The old cookies should eventually be removed once they reach their MaxAge.
c1bb90e
to
a5d5955
Compare
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label backport-risk-assessed |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
worked in #13513, fairly straightforward backport. If it must later be reverted, no complaints from me. |
800fe58
into
openshift:release-4.15
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.15.0-202402021608.p0.g800fe58.assembly.stream for distgit openshift-enterprise-console. |
This is a backport of #13513. It builds on top of #13514 to avoid needless merge conflicts.
/assign @jhadvig