OCPBUGS-22749: Adjust NAD name to "network-xxx-xxx" when creating

[hstastna]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-22749

Analysis / Root cause:
By using the Create network attachment definition dialog, an administrator may create two NADs in two different namespaces that would be connected to a single L2 network. There is nothing in the UI that indicates that namespace isolation is breached.

Solution Description:
Adjust new NetworkAttachmentDefinition name to be generated automatically and displayed in the Name input when creating a new NAD, to prevent creating a shared NAD between isolated namespaces. Add the popover ("?" icon) to inform the user that Networks are not project-bound. Using the same name creates a shared NAD.

Screen shots / Gifs for design review:
Before:

After:

[openshift-ci-robot]

@hstastna: This pull request references Jira Issue OCPBUGS-22749, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-22749

Analysis / Root cause:
By using the Create network attachment definition dialog, an administrator may create two NADs in two different namespaces that would be connected to a single L2 network. There is nothing in the UI that indicates that namespace isolation is breached.

Solution Description:
Adjust new NetworkAttachmentDefinition name to be generated automatically and displayed in the Name input when creating a new NAD, to prevent creating a shared NAD between isolated namespaces. Add the popover ("?" icon) to inform the user that Networks are not project-bound. Using the same name creates a shared NAD.

Screen shots / Gifs for design review:
Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hstastna]

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

[hstastna]

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

[hstastna]

/jira refresh

[openshift-ci-robot]

@hstastna: This pull request references Jira Issue OCPBUGS-22749, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (ycui@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[metalice]

/lgtm

[hstastna]

/retest

[openshift-ci]

@hstastna: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hstastna]

@rawagner Hi Rasto, could I ask you for approving this PR, please? 😊

[rawagner]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/network-attachment-definition-plugin/OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@hstastna: Jira Issue OCPBUGS-22749: All pull requests linked via external trackers have merged:

• openshift/console#13263
• openshift/console#13568

Jira Issue OCPBUGS-22749 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-22749

Analysis / Root cause:
By using the Create network attachment definition dialog, an administrator may create two NADs in two different namespaces that would be connected to a single L2 network. There is nothing in the UI that indicates that namespace isolation is breached.

Solution Description:
Adjust new NetworkAttachmentDefinition name to be generated automatically and displayed in the Name input when creating a new NAD, to prevent creating a shared NAD between isolated namespaces. Add the popover ("?" icon) to inform the user that Networks are not project-bound. Using the same name creates a shared NAD.

Screen shots / Gifs for design review:
Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-02-12-213938