ODC-7519: Update the Pipeline Topology to adjust the new node design for the CustomRun

[Lucifergene]

Fixes:
https://issues.redhat.com/browse/ODC-7519

Solution Description:

• Design the new CustomTask node
• Add the new icons to the console and use them as the Status Icons

Screen shots / Gifs for design review:

Tab-custom-task-beta.Pipeline.Details.OKD.mp4

Unit test coverage report:
Not Changed.

Test setup:

1. Install Pipelines operator and Install the ApprovalTask Controller following this Doc.
2. Execute the following gist: https://gist.github.com/Lucifergene/f491504d7eda8a97e86a132029a9bc7b

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@Lucifergene: This pull request references ODC-7519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7519

Solution Description:

• Design the new CustomTask node
• Add the new icons to the console and use them as the Status Icons

Screen shots / Gifs for design review:

Tab-custom-task-beta.Pipeline.Details.OKD.mp4

Unit test coverage report:
Not Changed.

Test setup:

1. Install Pipelines operator and Install the ApprovalTask Controller following this Doc.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@Lucifergene: This pull request references ODC-7519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7519

Solution Description:

• Design the new CustomTask node
• Add the new icons to the console and use them as the Status Icons

Screen shots / Gifs for design review:

Tab-custom-task-beta.Pipeline.Details.OKD.mp4

Unit test coverage report:
Not Changed.

Test setup:

1. Install Pipelines operator and Install the ApprovalTask Controller following this Doc.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Lucifergene]

/cc @jerolimov @lokanandaprabhu

[MariaLeonova]

@Lucifergene that looks good! From the visual POV I'd suggest having less padding on the sides of the run bubble itself - right now there seems to be a bit of extra space. I'm adding the sizes from the figma file:

So 8 px should be a good amount.

[Lucifergene]

/label docs-approved
/label px-approved

[Lucifergene]

@Lucifergene that looks good! From the visual POV I'd suggest having less padding on the sides of the run bubble itself - right now there seems to be a bit of extra space. I'm adding the sizes from the figma file: So 8 px should be a good amount.

Thanks @MariaLeonova! I have planned to adjust the paddings and spacings once the partially approved icons are implemented as part of the work for the next story. This will prevent any duplicate effort as part of the final touch-ups.

[openshift-ci-robot]

@Lucifergene: This pull request references ODC-7519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes:
https://issues.redhat.com/browse/ODC-7519

Solution Description:

• Design the new CustomTask node
• Add the new icons to the console and use them as the Status Icons

Screen shots / Gifs for design review:

Tab-custom-task-beta.Pipeline.Details.OKD.mp4

Unit test coverage report:
Not Changed.

Test setup:

1. Install Pipelines operator and Install the ApprovalTask Controller following this Doc.
2. Execute the following gist: https://gist.github.com/Lucifergene/f491504d7eda8a97e86a132029a9bc7b

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sanketpathak]

@MariaLeonova @Lucifergene The UI here for the wait task(approval task) doesn't give any idea to the user to approve or disapprove the task. It looks ambiguous.

[vikram-raj]

/lgtm
/approve

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 824a736 and 1 for PR HEAD 1f4e00f in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e56ab7e and 0 for PR HEAD 1f4e00f in total

[openshift-ci-robot]

/hold

Revision 1f4e00f was retested 3 times: holding

[Lucifergene]

/unhold

[lokanandaprabhu]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5077253 and 2 for PR HEAD 0861d82 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3bbcf7e and 1 for PR HEAD 0861d82 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8c91a27 and 0 for PR HEAD 0861d82 in total

[openshift-ci-robot]

/hold

Revision 0861d82 was retested 3 times: holding

[Lucifergene]

/unhold

[Lucifergene]

/retest

[vikram-raj]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[invincibleJai]

/label acknowledge-critical-fixes-only

[openshift-ci]

@Lucifergene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.