Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-29842: Switch to service from external result route endpoint #13627

Merged
merged 1 commit into from Mar 6, 2024
Merged

[release-4.15] OCPBUGS-29842: Switch to service from external result route endpoint #13627

merged 1 commit into from Mar 6, 2024

Conversation

vikram-raj
Copy link
Member

Manual cherry-pick PR #13624

@vikram-raj vikram-raj mentioned this pull request Feb 22, 2024
Merged
@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2024
@vikram-raj
Copy link
Member Author

/cc @jerolimov

@vikram-raj vikram-raj changed the title Switch to service from external result route endpoint [release-4.15] OCPBUGS-29842: Switch to service from external result route endpoint Feb 22, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 22, 2024
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-29842, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29816 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29816 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick PR #13624

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vikram-raj
vikram-raj commented Feb 26, 2024
View reviewed changes
Copy link
Member Author

@vikram-raj vikram-raj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

GH-13627.mov

@vikram-raj
Copy link
Member Author

/retest

@vikram-raj
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 26, 2024
@vikram-raj
Copy link
Member Author

/retest

@lokanandaprabhu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@The-Anton
Copy link
Member

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 28, 2024
@vikram-raj
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2024
@vikram-raj vikram-raj force-pushed the cherry-pick-13624-to-release-4.15 branch from d3bf9c0 to 89b5b05 Compare March 4, 2024 14:33
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2024
@lokanandaprabhu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f6aa7e8 and 2 for PR HEAD 89b5b05 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d4ddb9f and 1 for PR HEAD 89b5b05 in total

@vikram-raj
Copy link
Member Author

/retest

2 similar comments
@vikram-raj
Copy link
Member Author

/retest

@vikram-raj
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 931a2ed and 0 for PR HEAD 89b5b05 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a45aa76 into openshift:release-4.15 Mar 6, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: Jira Issue OCPBUGS-29842: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29842 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick PR #13624

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj vikram-raj deleted the cherry-pick-13624-to-release-4.15 branch March 6, 2024 06:46
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.15.0-202403060637.p0.ga45aa76.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-03-06-142724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokanandaprabhu lokanandaprabhu lokanandaprabhu approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

@jerolimov jerolimov Awaiting requested review from jerolimov

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@juzhao juzhao

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet