Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-25274: Add support for Azure Workload Identity / Federated Identity based in… #13642

Merged
merged 1 commit into from Mar 4, 2024
Merged

[release-4.14] OCPBUGS-25274: Add support for Azure Workload Identity / Federated Identity based in… #13642

merged 1 commit into from Mar 4, 2024

Conversation

rhamilto
Copy link
Member

…stalls in OperatorHub

@rhamilto
Copy link
Member Author

rhamilto commented Feb 29, 2024 •
edited

Replaces #13442 as this PR also incorporates fix from #13472

@openshift-ci openshift-ci bot added component/olm Related to OLM kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 29, 2024
@rhamilto
Copy link
Member Author

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 29, 2024
@rhamilto
Copy link
Member Author

@jcaianirh, mind tagging this?

@rhamilto rhamilto assigned jcaianirh and yanpzhan and unassigned jcaianirh Feb 29, 2024
@rhamilto rhamilto changed the title Add support for Azure Workload Identity / Federated Identity based in… [release-4.14] OCPBUGS-25274: Add support for Azure Workload Identity / Federated Identity based in… Feb 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-25274, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24680 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24680 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…stalls in OperatorHub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 29, 2024
@openshift-ci openshift-ci bot requested a review from yapei February 29, 2024 20:44
jcaianirh
jcaianirh approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

rhamilto commented Mar 1, 2024

/retest

5 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented Mar 1, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Mar 1, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Mar 1, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Mar 1, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Mar 1, 2024

/retest

@yapei
Copy link
Contributor

yapei commented Mar 4, 2024

verified that the warning info is shown on operator installation page
Screenshot 2024-03-04 at 10 07 32 AM
Screenshot 2024-03-04 at 10 08 02 AM
/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 4, 2024
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-25274, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24680 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24680 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

…stalls in OperatorHub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c636042 and 2 for PR HEAD 84b86a2 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c5c6009 into openshift:release-4.14 Mar 4, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@rhamilto: Jira Issue OCPBUGS-25274: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25274 has been moved to the MODIFIED state.

In response to this:

…stalls in OperatorHub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.14.0-202403040708.p0.gc5c6009.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@rhamilto rhamilto deleted the ocpbugs-25274 branch March 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@yapei yapei Awaiting requested review from yapei

Assignees

@yanpzhan yanpzhan

@jcaianirh jcaianirh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/olm Related to OLM jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet