Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3965: i18n upload/download routine task for version-4.16/ sprint-248 #13652

Merged
merged 1 commit into from Mar 14, 2024
Merged

CONSOLE-3965: i18n upload/download routine task for version-4.16/ sprint-248 #13652

merged 1 commit into from Mar 14, 2024

Conversation

cyril-ui-developer
Copy link
Contributor

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/ey37gmOfw78ld93mF186Q2

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3965 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/ey37gmOfw78ld93mF186Q2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Mar 6, 2024
TheRealJon
TheRealJon reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one Japanese translation for "Dashboards" was removed.

frontend/packages/dev-console/locales/ja/devconsole.json Outdated
@@ -627,14 +627,14 @@
"Select query": "クエリーの選択",
"Hide PromQL": "PromQL の非表示",
"Show PromQL": "PromQL の表示",
"Dashboard": "ダッシュボード",
"Dashboards": "Dashboard",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealJon I don't think so. Seems like a mistake to me. I have updated with the correct translation.
PTAL, thanks.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cyril-ui-developer
Copy link
Contributor Author

@TheRealJon Updated, PTAL

rhamilto
rhamilto approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@cyril-ui-developer
Copy link
Contributor Author

Adding these labels since the changes are translations in supported langs.
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2024 •
edited by openshift-ci bot

@cyril-ui-developer: This pull request references CONSOLE-3965 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/ey37gmOfw78ld93mF186Q2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 6642d3a into openshift:master Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon left review comments

@rhamilto rhamilto rhamilto approved these changes

@sg00dwin sg00dwin sg00dwin approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cyril-ui-developer @openshift-ci-robot @rhamilto @sg00dwin @TheRealJon