Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3972: add Last State to Pod details Container list and Conta… #13674

Merged
merged 1 commit into from Mar 22, 2024
Merged

CONSOLE-3972: add Last State to Pod details Container list and Conta… #13674

merged 1 commit into from Mar 22, 2024

Conversation

rhamilto
Copy link
Member

…iner details

Pod details page Containers list at various breakpoints

Untitled.mov

Container details page
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway

Empty state
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway (1)
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway (2)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2024 •
edited by openshift-ci bot

@rhamilto: This pull request references CONSOLE-3972 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

…iner details

Pod details page Containers list at various breakpoints

Untitled.mov

Container details page
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway

Empty state
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway (1)
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway (2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dtaylor113 and kyoto March 14, 2024 20:54
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2024
@rhamilto rhamilto force-pushed the CONSOLE-3972 branch 2 times, most recently from 12b94a6 to a7cc6b9 Compare March 14, 2024 21:07
@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

Code Approver:
/assign @jhadvig
QE Approver:
/assign @yapei
Docs Approver:
/assign @opayne1
PX Approver:
/assign @RickJWagner

@opayne1
Copy link
Contributor

opayne1 commented Mar 15, 2024

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 15, 2024
@RickJWagner
Copy link

/label px-approved

@RickJWagner RickJWagner removed their assignment Mar 15, 2024
@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Mar 15, 2024
@rhamilto
Copy link
Member Author

/retest

2 similar comments
@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

/retest

@yanpzhan
Copy link
Contributor

@rhamilto I tested the pr and added a case for it, could you help to review the case? Thanks! case link: https://polarion.engineering.redhat.com/polarion/redirect/project/OSE/workitem?id=OCP-72714

@yanpzhan
Copy link
Contributor

@rhamilto The pr still has work-in-progress label, will there be other update in code?

@rhamilto
Copy link
Member Author

@rhamilto The pr still has work-in-progress label, will there be other update in code?

@yanpzhan, I don't expect there will be changes, but this PR is waiting on code approval from @jhadvig who has been out on PTO.

jhadvig
jhadvig reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks right to me. Adding one small comment.

frontend/public/components/pod.tsx
} else if (containerLastState?.terminated) {
return (
<Trans t={t} ns="public">
Terminated <ContainerTerminatedAt finishedAt={containerLastState.terminated?.finishedAt} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have the render logic be part of a single component rather then three separate ones, since they are not used anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The separate components are necessary since the data is optional

@jhadvig jhadvig changed the title [WIP] CONSOLE-3972: add Last Status to Pod details Container list and Conta… CONSOLE-3972: add Last Status to Pod details Container list and Conta… Mar 21, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@rhamilto
Copy link
Member Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 21, 2024
jhadvig
jhadvig approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 22, 2024 •
edited by openshift-ci bot

@rhamilto: This pull request references CONSOLE-3972 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

…iner details

Pod details page Containers list at various breakpoints

Untitled.mov

Container details page
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway

Empty state
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway (1)
localhost_9000_k8s_ns_knative-serving-ingress_pods_3scale-kourier-gateway-79bc5c58d9-c2lw7_containers_kourier-gateway (2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5b83674 into openshift:master Mar 22, 2024
6 checks passed
@rhamilto rhamilto deleted the CONSOLE-3972 branch March 22, 2024 16:20
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202403221545.p0.g5b83674.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@rhamilto rhamilto changed the title CONSOLE-3972: add Last Status to Pod details Container list and Conta… CONSOLE-3972: add Last State to Pod details Container list and Conta… Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@jhadvig jhadvig

@yapei yapei

@opayne1 opayne1

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rhamilto @openshift-ci-robot @opayne1 @RickJWagner @yanpzhan @openshift-bot @jhadvig @yapei