Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7431: dev-console test package update concerning pf5 update #13685

Merged
merged 1 commit into from Apr 2, 2024
Merged

ODC-7431: dev-console test package update concerning pf5 update #13685

merged 1 commit into from Apr 2, 2024

Conversation

The-Anton
Copy link
Member

@The-Anton The-Anton commented Mar 20, 2024 •
edited

Fix: ODC-7431

Description:
Remove PatternFly classname selectors from dev-console integration tests

Test Setup:

Check the TAGS in frontend/packages/dev-console/integration-tests/cypress.config.js file be:

(@pre-condition or @smoke or @regression) and not (@manual or @to-do or @un-verified or @broken-test)

Command to execute:

Example:

    export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
    BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
    BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/
    export BRIDGE_KUBEADMIN_PASSWORD
    export BRIDGE_BASE_ADDRESS
    oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
    oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
    oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
    ./test-cypress.sh -p dev-console

Browser
Chrome 116

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot

@The-Anton: This pull request references ODC-7431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fix: ODC-7431

Description:
Remove PatternFly classname selectors from dev-console integration tests

Test Setup:

Check the TAGS in frontend/packages/shipwright/integration-tests/cypress.config.js file be:

(@pre-condition or @smoke or @regression) and not (@manual or @to-do or @un-verified or @broken-test)

Command to execute:

Example:

   export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
   BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
   BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/
   export BRIDGE_KUBEADMIN_PASSWORD
   export BRIDGE_BASE_ADDRESS
   oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
   oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
   oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
   ./test-cypress.sh -p dev-console

Browser
Chrome 116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot

@The-Anton: This pull request references ODC-7431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fix: ODC-7431

Description:
Remove PatternFly classname selectors from dev-console integration tests

Test Setup:

Check the TAGS in frontend/packages/dev-console/integration-tests/cypress.config.js file be:

(@pre-condition or @smoke or @regression) and not (@manual or @to-do or @un-verified or @broken-test)

Command to execute:

Example:

   export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
   BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
   BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/
   export BRIDGE_KUBEADMIN_PASSWORD
   export BRIDGE_BASE_ADDRESS
   oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
   oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
   oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
   ./test-cypress.sh -p dev-console

Browser
Chrome 116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Mar 20, 2024
@The-Anton The-Anton changed the title ODC-7431: Knative test package update concerning pf5 update ODC-7431: dev-console test package update concerning pf5 update Mar 20, 2024
sanketpathak
sanketpathak reviewed Apr 1, 2024
View reviewed changes
frontend/packages/dev-console/integration-tests/support/pageObjects/add-flow-po.ts Outdated
@@ -5,7 +5,7 @@ export const addPagePO = {
detailsOnOffSwitch: '[data-test="details-switch"]',
cardDetails: 'p.odc-add-card-item__description',
restoreGettingStarted: '[data-test="restore-getting-started"]',
kebabMenuGettingStarted: '[data-test="actions"]',
toogleGettingStarted: '[id*="expandable-section-toogle"]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
toogleGettingStarted: '[id*="expandable-section-toogle"]',
toogleGettingStarted: '[id*="expandable-section-toggle"]',

@sanketpathak
Copy link
Contributor

Tests run green
/lgtm

@sanketpathak
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanketpathak, The-Anton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@sanketpathak
Copy link
Contributor

The pr only edits e2e tests
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 2, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 2, 2024 •
edited by openshift-ci bot

@The-Anton: This pull request references ODC-7431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fix: ODC-7431

Description:
Remove PatternFly classname selectors from dev-console integration tests

Test Setup:

Check the TAGS in frontend/packages/dev-console/integration-tests/cypress.config.js file be:

(@pre-condition or @smoke or @regression) and not (@manual or @to-do or @un-verified or @broken-test)

Command to execute:

Example:

   export NO_HEADLESS=true && export CHROME_VERSION=$(/usr/bin/google-chrome-stable --version)
   BRIDGE_KUBEADMIN_PASSWORD=YH3jN-PRFT2-Q429c-5KQDr
   BRIDGE_BASE_ADDRESS=https://console-openshift-console.apps.dev-svc-4.13-042801.devcluster.openshift.com/
   export BRIDGE_KUBEADMIN_PASSWORD
   export BRIDGE_BASE_ADDRESS
   oc login -u kubeadmin -p $BRIDGE_KUBEADMIN_PASSWORD
   oc apply -f ./frontend/integration-tests/data/htpasswd-secret.yaml
   oc patch oauths cluster --patch "$(cat ./frontend/integration-tests/data/patch-htpasswd.yaml)" --type=merge
   ./test-cypress.sh -p dev-console

Browser
Chrome 116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@The-Anton: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 26652ad into openshift:master Apr 2, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404021444.p0.g26652ad.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketpathak sanketpathak sanketpathak left review comments

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@sanketpathak sanketpathak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@The-Anton @openshift-ci-robot @sanketpathak @openshift-bot