Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CONSOLE-3970: add Lightspeed widget, modal, and extension point #13708

Closed
wants to merge 4 commits into from

Conversation

rhamilto
Copy link
Member

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 27, 2024

@rhamilto: This pull request references CONSOLE-3970 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@rhamilto
Copy link
Member Author

@vojtechszocs, what am I missing here? I added a new checkbox preference, but clicking the checkbox does not toggle it off.

Screen.Recording.2024-03-27.at.5.20.20.PM.mov

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Mar 27, 2024
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2024
@rhamilto
Copy link
Member Author

@vojtechszocs, what am I missing here? I added a new checkbox preference, but clicking the checkbox does not toggle it off.

Screen.Recording.2024-03-27.at.5.20.20.PM.mov

This appears to be the result of a bug in the SDK caused by "defaultValue": true. Working around the bug by changing the preference from show to hide so a default value of false can be used instead.

@rhamilto
Copy link
Member Author

@rhamilto
Copy link
Member Author

rhamilto commented Mar 29, 2024

Prototyped the Lightspeed contents going in a resizable drawer instead of a popover. (Note: the User Preferences dropdown width bug is existing.)

Screen.Recording.2024-03-29.at.4.05.28.PM.mov

Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

@rhamilto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console e9e1849 link true /test e2e-gcp-console
ci/prow/frontend e9e1849 link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

rhamilto commented Apr 1, 2024

Putting this work on hold as it is not needed until 4.17, and we want to take some time to work through finalizing the design before implementation.

@rhamilto rhamilto closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants