Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7437: Remove pf classes in topology package #13710

Merged
merged 1 commit into from Apr 27, 2024
Merged

ODC-7437: Remove pf classes in topology package #13710

merged 1 commit into from Apr 27, 2024

Conversation

sanketpathak
Copy link
Contributor

Fix:ODC-7437

Description:
Remove PatternFly classname selectors from topology integration tests

Command to execute:
Run a cluster locally and execute the command yarn run dev and then yarn run test-cypress-topology simultaneously

Browser
Chrome 120

Test Execution Screenshot:
Screenshot 2024-03-31 at 2 44 54 AM

@openshift-ci openshift-ci bot added component/knative Related to knative-plugin component/topology Related to topology labels Apr 1, 2024
@sanketpathak
Copy link
Contributor Author

/retest

@jerolimov
Copy link
Member

@sanketpathak @The-Anton Apply approval just for the new data-test prop, I didn't check the integrations test code.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@The-Anton
Copy link
Member

Tests are passing.
/lgtm

Screenshot 2024-04-09 at 3 46 10 PM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@jerolimov
Copy link
Member

/retest

2 similar comments
@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/retest

@sanketpathak
Copy link
Contributor Author

Pr edits only e2e tests
/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Apr 17, 2024
@sanketpathak sanketpathak changed the title Remove pf classes in topology package ODC-7437: Remove pf classes in topology package Apr 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 17, 2024 •
edited by openshift-ci bot

@sanketpathak: This pull request references ODC-7437 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Fix:ODC-7437

Description:
Remove PatternFly classname selectors from topology integration tests

Command to execute:
Run a cluster locally and execute the command yarn run dev and then yarn run test-cypress-topology simultaneously

Browser
Chrome 120

Test Execution Screenshot:
Screenshot 2024-03-31 at 2 44 54 AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sanketpathak
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f666ce3 and 2 for PR HEAD f7c026b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7b8d108 and 1 for PR HEAD f7c026b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8ef3b38 and 0 for PR HEAD f7c026b in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision f7c026b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@sanketpathak
Copy link
Contributor Author

/test e2e-gcp-console

@sanketpathak
Copy link
Contributor Author

/retest

2 similar comments
@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

/retest

@sanketpathak sanketpathak force-pushed the topology-test-update-pf5-change branch from f7c026b to 49532a7 Compare April 24, 2024 08:39
@openshift-ci openshift-ci bot added component/helm Related to helm-plugin and removed lgtm Indicates that a PR is ready to be merged. labels Apr 24, 2024
jerolimov
jerolimov approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, sanketpathak, The-Anton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a0ef83f and 2 for PR HEAD 49532a7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d6fa143 and 1 for PR HEAD 49532a7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6c7e5f0 and 0 for PR HEAD 49532a7 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 49532a7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@jerolimov
Copy link
Member

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dfe987f and 2 for PR HEAD 49532a7 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD acd4ec1 and 1 for PR HEAD 49532a7 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 27, 2024

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a80f7dd into openshift:master Apr 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@jerolimov jerolimov

@The-Anton The-Anton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/helm Related to helm-plugin component/knative Related to knative-plugin component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sanketpathak @jerolimov @The-Anton @openshift-ci-robot