New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29377: Routes created by devfiles do not always use HTTPS #13725
OCPBUGS-29377: Routes created by devfiles do not always use HTTPS #13725
Conversation
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-29377, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-29377, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @jerolimov |
@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-29377, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu, Lucifergene, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4550baa
into
openshift:master
@lokanandaprabhu: Jira Issue OCPBUGS-29377: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29377 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.15 |
@lokanandaprabhu: new pull request created: #13771 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/OCPBUGS-29377
Analysis / Root cause:
tls settings defined for devfile is not considered while creating the route.
Solution Description:
Updated Import flow to consider tls settings defined for route and provided user the checkbox to secure the route. The checkbox to secure route will only be displayed if tls setting is defined for the devfile or else route will be created with http.
Screen shots / Gifs for design review:
Screen.Recording.2024-04-04.at.11.09.16.AM.mov
Unit test coverage report:
NA
Test setup:
or
Browser conformance: