OCPBUGS-31809: Pipeline details page Metrics tab crashed due to no custom data

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31809

Analysis / Root cause:
While doing the migration of Pipeline details page, Metrics page is expecting customData from Details page - https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-metrics/PipelineMetrics.tsx but in horizontalnav component exposed to dynamic plugin, we don't have customData prop. https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/docs/api.md#horizontalnav

Solution Description:
Calling customData values inside Metrics page

Screen shots / Gifs for design review:

---Before--

--After--

Unit test coverage report:
NA

Test setup:

1. Pipeline details page PR to be up for testing this[WIP][Story - https://issues.redhat.com/browse/ODC-7525]
2. Install Pipelines Operator and don't install Tekton result
3. Enabled Pipeline details page in dynamic plugin
4. create a pipeline and go to Metrics tab in details page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-31809, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31809

Analysis / Root cause:
While doing the migration of Pipeline details page, Metrics page is expecting customData from Details page - https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-metrics/PipelineMetrics.tsx but in horizontalnav component exposed to dynamic plugin, we don't have customData prop. https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/docs/api.md#horizontalnav

Solution Description:
Calling customData values inside Metrics page

Screen shots / Gifs for design review:

---Before--

--After--

Unit test coverage report:
NA

Test setup:

1. Pipeline details page PR to be up for testing this[WIP]
2. Install Pipelines Operator and don't install Tekton result
3. Enabled Pipeline details page in dynamic plugin
4. create a pipeline and go to Metrics tab in details page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/cc @vikram-raj @jerolimov

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-31809, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31809

Analysis / Root cause:
While doing the migration of Pipeline details page, Metrics page is expecting customData from Details page - https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-metrics/PipelineMetrics.tsx but in horizontalnav component exposed to dynamic plugin, we don't have customData prop. https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/docs/api.md#horizontalnav

Solution Description:
Calling customData values inside Metrics page

Screen shots / Gifs for design review:

---Before--

--After--

Unit test coverage report:
NA

Test setup:

1. Pipeline details page PR to be up for testing this[WIP][Story - https://issues.redhat.com/browse/ODC-7525]
2. Install Pipelines Operator and don't install Tekton result
3. Enabled Pipeline details page in dynamic plugin
4. create a pipeline and go to Metrics tab in details page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lokanandaprabhu]

/retest

[openshift-ci]

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Lucifergene]

/lgtm

[vikram-raj]

Verified
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@lokanandaprabhu: Jira Issue OCPBUGS-31809: All pull requests linked via external trackers have merged:

• openshift/console#13733

Jira Issue OCPBUGS-31809 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31809

Analysis / Root cause:
While doing the migration of Pipeline details page, Metrics page is expecting customData from Details page - https://github.com/openshift/console/blob/master/frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-metrics/PipelineMetrics.tsx but in horizontalnav component exposed to dynamic plugin, we don't have customData prop. https://github.com/openshift/console/blob/master/frontend/packages/console-dynamic-plugin-sdk/docs/api.md#horizontalnav

Solution Description:
Calling customData values inside Metrics page

Screen shots / Gifs for design review:

---Before--

--After--

Unit test coverage report:
NA

Test setup:

1. Pipeline details page PR to be up for testing this[WIP][Story - https://issues.redhat.com/browse/ODC-7525]
2. Install Pipelines Operator and don't install Tekton result
3. Enabled Pipeline details page in dynamic plugin
4. create a pipeline and go to Metrics tab in details page

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404190512.p0.g1641e81.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

[jerolimov]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@jerolimov: new pull request created: #13781

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-21-123502