Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32019: Handle loading issue for PLR status in PLR list page #13747

Merged

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32019

Analysis / Root cause:
TaskRuns added to cache without complete loading

Solution Description:
Added taskRuns to cache only after loading is completed

Screen shots / Gifs for design review:

---Before--

Screen.Recording.2024-04-10.at.1.13.52.PM.mov

--After--

Screen.Recording.2024-04-10.at.1.20.10.PM.mov

Unit test coverage report:
NA

Test setup:

1.Create a failed pipelinerun
2.Check Task Status field

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 10, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32019, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32019

Analysis / Root cause:
TaskRuns added to cache without complete loading

Solution Description:
Added taskRuns to cache only after loading is completed

Screen shots / Gifs for design review:

---Before--

Screen.Recording.2024-04-10.at.1.13.52.PM.mov

--After--

Screen.Recording.2024-04-10.at.1.20.10.PM.mov

Unit test coverage report:
NA

Test setup:

1.Create a failed pipelinerun
2.Check Task Status field

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/cc @karthikjeeyar @vikram-raj

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Apr 10, 2024
Copy link
Contributor

@Lucifergene Lucifergene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, Lucifergene, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7b8d108 into openshift:master Apr 17, 2024
5 of 6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-32019: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32019 has been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32019

Analysis / Root cause:
TaskRuns added to cache without complete loading

Solution Description:
Added taskRuns to cache only after loading is completed

Screen shots / Gifs for design review:

---Before--

Screen.Recording.2024-04-10.at.1.13.52.PM.mov

--After--

Screen.Recording.2024-04-10.at.1.20.10.PM.mov

Unit test coverage report:
NA

Test setup:

1.Create a failed pipelinerun
2.Check Task Status field

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-21-123502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants