Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32189: Fix PatternFly version resolution check script for MacOS #13757

Merged

Conversation

vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Apr 12, 2024

Modified the grep command not to use -P, --perl-regexp option (Perl-compatible regex aka PCRE) since that seems to be unsupported by MacOS version of the grep binary.

The pattern ^\"${PKG_NAME}@ is very simple and therefore no need for neither -P, --perl-regexp nor -E, --extended-regexp options to be enabled.

Also modified color escape sequences - the \033[XXXm format should be ANSI compatible and should work on MacOS.

This PR also updates the yarn.lock file of dynamic demo plugin to match the current dependency resolutions.

@openshift-ci openshift-ci bot requested review from kyoto and spadgett April 12, 2024 16:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@vojtechszocs vojtechszocs changed the title Fix PatternFly version resolution check script for MacOS OCPBUGS-32189: Fix PatternFly version resolution check script for MacOS Apr 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 12, 2024
@openshift-ci-robot
Copy link
Contributor

@vojtechszocs: This pull request references Jira Issue OCPBUGS-32189, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Modified the grep command not to use -P, --perl-regexp option (Perl-compatible regex aka PCRE) since that seems to be unsupported by MacOS version of the grep binary.

The pattern "^\"${PKG_NAME}@" is very simple and therefore no need for neither -P, --perl-regexp nor -E, --extended-regexp options to be enabled.

Also modified color escape sequences - the \033[XXXm format should be ANSI compatible and should work on MacOS.

This PR also updates the yarn.lock file of dynamic demo plugin to match the current dependency resolutions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member

Tested on Mac and the script runs and is output is correctly colored. Thanks, @vojtechszocs!

Screenshot 2024-04-12 at 1 49 31 PM

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Apr 15, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 15, 2024
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-32189, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei April 15, 2024 09:48
@openshift-ci-robot
Copy link
Contributor

@vojtechszocs: This pull request references Jira Issue OCPBUGS-32189, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Modified the grep command not to use -P, --perl-regexp option (Perl-compatible regex aka PCRE) since that seems to be unsupported by MacOS version of the grep binary.

The pattern ^\"${PKG_NAME}@ is very simple and therefore no need for neither -P, --perl-regexp nor -E, --extended-regexp options to be enabled.

Also modified color escape sequences - the \033[XXXm format should be ANSI compatible and should work on MacOS.

This PR also updates the yarn.lock file of dynamic demo plugin to match the current dependency resolutions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a66e79 into openshift:master Apr 16, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vojtechszocs: Jira Issue OCPBUGS-32189: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32189 has been moved to the MODIFIED state.

In response to this:

Modified the grep command not to use -P, --perl-regexp option (Perl-compatible regex aka PCRE) since that seems to be unsupported by MacOS version of the grep binary.

The pattern ^\"${PKG_NAME}@ is very simple and therefore no need for neither -P, --perl-regexp nor -E, --extended-regexp options to be enabled.

Also modified color escape sequences - the \033[XXXm format should be ANSI compatible and should work on MacOS.

This PR also updates the yarn.lock file of dynamic demo plugin to match the current dependency resolutions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404160414.p0.g5a66e79.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-16-195622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants