New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-32189: Fix PatternFly version resolution check script for MacOS #13757
OCPBUGS-32189: Fix PatternFly version resolution check script for MacOS #13757
Conversation
@vojtechszocs: This pull request references Jira Issue OCPBUGS-32189, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Tested on Mac and the script runs and is output is correctly colored. Thanks, @vojtechszocs! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@jhadvig: This pull request references Jira Issue OCPBUGS-32189, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vojtechszocs: This pull request references Jira Issue OCPBUGS-32189, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@vojtechszocs: Jira Issue OCPBUGS-32189: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32189 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404160414.p0.g5a66e79.assembly.stream.el9 for distgit openshift-enterprise-console. |
Fix included in accepted release 4.16.0-0.nightly-2024-04-16-195622 |
Modified the grep command not to use
-P, --perl-regexp
option (Perl-compatible regex aka PCRE) since that seems to be unsupported by MacOS version of the grep binary.The pattern
^\"${PKG_NAME}@
is very simple and therefore no need for neither-P, --perl-regexp
nor-E, --extended-regexp
options to be enabled.Also modified color escape sequences - the
\033[XXXm
format should be ANSI compatible and should work on MacOS.This PR also updates the
yarn.lock
file of dynamic demo plugin to match the current dependency resolutions.