Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINC-1180: Use record created for container_network metrics #13759

Merged

Conversation

mansikulkarni96
Copy link
Member

This commit updates the container_network pod metrics to use the newly introduced recording rules in the CMO repository.
Ref: openshift/cluster-monitoring-operator#2314

This commit updates the container_network pod metrics
to use the newly introduced recording rules in the
CMO repository.
Ref: openshift/cluster-monitoring-operator#2314
@mansikulkarni96 mansikulkarni96 changed the title Use record created for container_network metrics WINC-1180: Use record created for container_network metrics Apr 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2024

@mansikulkarni96: This pull request references WINC-1180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "WMCO 10.16.0" instead.

In response to this:

This commit updates the container_network pod metrics to use the newly introduced recording rules in the CMO repository.
Ref: openshift/cluster-monitoring-operator#2314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2024
@openshift-ci openshift-ci bot requested review from jan--f and jhadvig April 16, 2024 05:40
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared labels Apr 16, 2024
@jan--f
Copy link
Contributor

jan--f commented Apr 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@mansikulkarni96
Copy link
Member Author

/test e2e-gcp-console

@mansikulkarni96
Copy link
Member Author

/retest-required

@TheRealJon
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, mansikulkarni96, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@mansikulkarni96
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@mansikulkarni96: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davemulford
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 18, 2024
@rphillips
Copy link

@jerolimov can you approve for docs and qe?

@rrasouli
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 20, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 20, 2024

@mansikulkarni96: This pull request references WINC-1180 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "WMCO 10.16.0" instead.

In response to this:

This commit updates the container_network pod metrics to use the newly introduced recording rules in the CMO repository.
Ref: openshift/cluster-monitoring-operator#2314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Member

Docs approver
/assign @opayne1

@opayne1
Copy link
Contributor

opayne1 commented Apr 24, 2024

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 24, 2024
@mansikulkarni96
Copy link
Member Author

/tide refresh

@mansikulkarni96
Copy link
Member Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 48c1f14 into openshift:master Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants