Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32222: Add warning about service binding operator will not be supported from 4.15 #13766

Merged

Conversation

lokanandaprabhu
Copy link
Contributor

Issue: https://issues.redhat.com/browse/OCPBUGS-32222

To Test:
You can test the product name using window.SERVER_FLAGS.branding or in local using ./bin/bridge -branding 'openshift'

Screenshots:

---Topology Page---

Screenshot 2024-04-17 at 11 27 03 AM Screenshot 2024-04-17 at 11 27 23 AM Screenshot 2024-04-17 at 11 28 40 AM Screenshot 2024-04-17 at 11 29 21 AM

---Service Binding list page---

Screenshot 2024-04-17 at 11 29 41 AM

---Service Binding details page---

Screenshot 2024-04-17 at 11 29 51 AM

---Catalog details side panel---

Screenshot 2024-04-17 at 11 30 16 AM

---Create Service Binding modal---
Screenshot 2024-04-17 at 11 30 39 AM

---Developer catalog page help text---
Screenshot 2024-04-17 at 12 54 01 PM

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 17, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32222, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-32222

To Test:
You can test the product name using window.SERVER_FLAGS.branding or in local using ./bin/bridge -branding 'openshift'

Screenshots:

---Topology Page---

Screenshot 2024-04-17 at 11 27 03 AM Screenshot 2024-04-17 at 11 27 23 AM Screenshot 2024-04-17 at 11 28 40 AM Screenshot 2024-04-17 at 11 29 21 AM

---Service Binding list page---

Screenshot 2024-04-17 at 11 29 41 AM

---Service Binding details page---

Screenshot 2024-04-17 at 11 29 51 AM

---Catalog details side panel---

Screenshot 2024-04-17 at 11 30 16 AM

---Create Service Binding modal---
Screenshot 2024-04-17 at 11 30 39 AM

---Developer catalog page help text---
Screenshot 2024-04-17 at 12 54 01 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/cc @jerolimov @vikram-raj @Lucifergene

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Apr 17, 2024
@lokanandaprabhu
Copy link
Contributor Author

/retest

1 similar comment
@jerolimov
Copy link
Member

/retest

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on a cluster bot and it looks nice 👍

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2024
@jerolimov
Copy link
Member

/retitle OCPBUGS-32222: Add warning about service binding operator will not be supported from 4.15

@openshift-ci openshift-ci bot changed the title OCPBUGS-32222: Add warning about service binding operator will not be supported from 4.16 OCPBUGS-32222: Add warning about service binding operator will not be supported from 4.15 Apr 19, 2024
@lokanandaprabhu
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@lokanandaprabhu: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Alert background color is same as modal background color in the dark theme.
image
  • Left and right padding should be added here and background color in dark theme is same here as well
image

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@lokanandaprabhu
Copy link
Contributor Author

Screenshot 2024-04-19 at 4 55 21 PM Screenshot 2024-04-19 at 4 55 32 PM Screenshot 2024-04-19 at 4 56 35 PM Screenshot 2024-04-19 at 4 56 25 PM

Hi @vikram-raj / @jerolimov ,

Made the requested changes for dark mode. PTAL.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lokanandaprabhu
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a77427c and 2 for PR HEAD 8ed4d98 in total

@jerolimov
Copy link
Member

/retest

1 similar comment
@jerolimov
Copy link
Member

/retest

@jerolimov
Copy link
Member

Deprecation warning ...

/label px-approved
/label docs-approved
/label qe-approved
/cc @sanketpathak

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 20, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32222, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-32222

To Test:
You can test the product name using window.SERVER_FLAGS.branding or in local using ./bin/bridge -branding 'openshift'

Screenshots:

---Topology Page---

Screenshot 2024-04-17 at 11 27 03 AM Screenshot 2024-04-17 at 11 27 23 AM Screenshot 2024-04-17 at 11 28 40 AM Screenshot 2024-04-17 at 11 29 21 AM

---Service Binding list page---

Screenshot 2024-04-17 at 11 29 41 AM

---Service Binding details page---

Screenshot 2024-04-17 at 11 29 51 AM

---Catalog details side panel---

Screenshot 2024-04-17 at 11 30 16 AM

---Create Service Binding modal---
Screenshot 2024-04-17 at 11 30 39 AM

---Developer catalog page help text---
Screenshot 2024-04-17 at 12 54 01 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jerolimov
Copy link
Member

/cherry-pick release-4.15

@openshift-cherrypick-robot

@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1504875 and 1 for PR HEAD 8ed4d98 in total

@jerolimov
Copy link
Member

/retest

1 similar comment
@lokanandaprabhu
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a7a48f3 into openshift:master Apr 22, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-32222: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32222 has been moved to the MODIFIED state.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-32222

To Test:
You can test the product name using window.SERVER_FLAGS.branding or in local using ./bin/bridge -branding 'openshift'

Screenshots:

---Topology Page---

Screenshot 2024-04-17 at 11 27 03 AM Screenshot 2024-04-17 at 11 27 23 AM Screenshot 2024-04-17 at 11 28 40 AM Screenshot 2024-04-17 at 11 29 21 AM

---Service Binding list page---

Screenshot 2024-04-17 at 11 29 41 AM

---Service Binding details page---

Screenshot 2024-04-17 at 11 29 51 AM

---Catalog details side panel---

Screenshot 2024-04-17 at 11 30 16 AM

---Create Service Binding modal---
Screenshot 2024-04-17 at 11 30 39 AM

---Developer catalog page help text---
Screenshot 2024-04-17 at 12 54 01 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@lokanandaprabhu: new pull request created: #13784

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202404220845.p0.ga7a48f3.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-23-032717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants