Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7565: Update owners files (remove reviewers and add Avik and Prabhu as approvers for ODC) #13773

Merged
merged 1 commit into from Apr 20, 2024

Conversation

jerolimov
Copy link
Member

Changes for packages and plugins that are maintained by the ODC-team:

  1. Add @lokanandaprabhu and @Lucifergene to the approver list if a change only affects the ODC base
  2. Add @The-Anton as a reviewer for all integration-tests folders
  3. Remove people who don't work on the ODC code base every day anymore. You can still add an lgtm label, but we hope that this helps the ci bot assign the right people.

/cc @vikram-raj

@openshift-ci openshift-ci bot requested a review from vikram-raj April 18, 2024 10:28
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/git-service Related to git-service approved Indicates a PR has been approved by an approver from all required OWNERS files. component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology labels Apr 18, 2024
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerolimov
Copy link
Member Author

As this doesn't affect our code or product

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 18, 2024
@jerolimov jerolimov changed the title Update owners files (remove reviewers and add Avik and Prabhu as approvers for ODC) ODC-7565: Update owners files (remove reviewers and add Avik and Prabhu as approvers for ODC) Apr 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2024

@jerolimov: This pull request references ODC-7565 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Changes for packages and plugins that are maintained by the ODC-team:

  1. Add @lokanandaprabhu and @Lucifergene to the approver list if a change only affects the ODC base
  2. Add @The-Anton as a reviewer for all integration-tests folders
  3. Remove people who don't work on the ODC code base every day anymore. You can still add an lgtm label, but we hope that this helps the ci bot assign the right people.

/cc @vikram-raj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jerolimov
Copy link
Member Author

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bd85036 and 2 for PR HEAD 217223d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c147452 and 1 for PR HEAD 217223d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 240719d and 0 for PR HEAD 217223d in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 217223d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@jerolimov
Copy link
Member Author

/unhold
/override e2e-gcp-console

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-console

Only the following failed contexts/checkruns were expected:

  • ci/prow/analyze
  • ci/prow/backend
  • ci/prow/e2e-gcp-console
  • ci/prow/frontend
  • ci/prow/images
  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/unhold
/override e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a77427c and 2 for PR HEAD 217223d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 71cee39 and 1 for PR HEAD 217223d in total

Copy link
Contributor

openshift-ci bot commented Apr 20, 2024

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 96c24f3 into openshift:master Apr 20, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404200345.p0.g96c24f3.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants