Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32791,CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier #13786

Merged
merged 2 commits into from Apr 26, 2024
Merged

OCPBUGS-32791,CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier #13786

merged 2 commits into from Apr 26, 2024

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Apr 22, 2024 •
edited

This is the frontend part related to openshift/console-operator#889

  1. Consume SERVER_FLAGS.telemetry.CLUSTER_ID and pass it together with other clusterProperties to segment.
  2. Use the clusterId and organizationId to calculate the anonymized user identifier for segment.
  3. Extract the "debug" feature for log every event into a separate listener extension.

I've tested this together with 889 on a cluster bot:

CONSOLE-4014.mp4

/cc @jhadvig @TheRealJon

@openshift-ci openshift-ci bot added component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2024
@jerolimov
Copy link
Member Author

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

jhadvig
jhadvig reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jerolimov 👍
Adding couple of comments

frontend/packages/console-telemetry-plugin/src/listeners/segment.ts Outdated Show resolved Hide resolved
frontend/packages/console-telemetry-plugin/src/listeners/segment.ts Show resolved Hide resolved
frontend/packages/console-telemetry-plugin/src/listeners/segment.ts Show resolved Hide resolved
@jhadvig jhadvig changed the title Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier Apr 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024 •
edited by openshift-ci bot

@jerolimov: This pull request references CONSOLE-4014 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This is the frontend part related to openshift/console-operator#889

  1. Consume SERVER_FLAGS.telemetry.CLUSTER_ID and pass it together with other clusterProperties to segment.
  2. Use the clusterId and organizationId to calculate the anonymized user identifier for segment.
  3. Extract the "debug" feature for log every event into a separate listener extension.

WIP: I will do a cluster bot demo with both PRs together...

/cc @jhadvig @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Apr 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024 •
edited by openshift-ci bot

@jerolimov: This pull request references CONSOLE-4014 which is a valid jira issue.

In response to this:

This is the frontend part related to openshift/console-operator#889

  1. Consume SERVER_FLAGS.telemetry.CLUSTER_ID and pass it together with other clusterProperties to segment.
  2. Use the clusterId and organizationId to calculate the anonymized user identifier for segment.
  3. Extract the "debug" feature for log every event into a separate listener extension.

I've tested this together with 889 on a cluster bot:

CONSOLE-4014.mp4

/cc @jhadvig @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jerolimov jerolimov requested a review from jhadvig April 24, 2024 10:00
@jerolimov jerolimov changed the title CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier OCPBUGS-32791, CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier Apr 24, 2024
@jerolimov jerolimov mentioned this pull request Apr 24, 2024
Open
@jerolimov jerolimov changed the title OCPBUGS-32791, CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier OCPBUGS-32791,CONSOLE-4014: Consume telemetry CLUSTER_ID and use it together with orgId as segment identifier Apr 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024 •
edited by openshift-ci bot

@jerolimov: This pull request references Jira Issue OCPBUGS-32791, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4014 which is a valid jira issue.

In response to this:

This is the frontend part related to openshift/console-operator#889

  1. Consume SERVER_FLAGS.telemetry.CLUSTER_ID and pass it together with other clusterProperties to segment.
  2. Use the clusterId and organizationId to calculate the anonymized user identifier for segment.
  3. Extract the "debug" feature for log every event into a separate listener extension.

I've tested this together with 889 on a cluster bot:

CONSOLE-4014.mp4

/cc @jhadvig @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig
jhadvig approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jerolimov 👍
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@jhadvig
Copy link
Member

jhadvig commented Apr 24, 2024

/retest

1 similar comment
@jerolimov
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d6fa143 and 0 for PR HEAD 843c3c9 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 843c3c9 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@jerolimov
Copy link
Member Author

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d6fa143 and 2 for PR HEAD 843c3c9 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@yapei
Copy link
Contributor

yapei commented Apr 25, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2024 •
edited by openshift-ci bot

@jerolimov: This pull request references Jira Issue OCPBUGS-32791, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

This pull request references CONSOLE-4014 which is a valid jira issue.

In response to this:

This is the frontend part related to openshift/console-operator#889

  1. Consume SERVER_FLAGS.telemetry.CLUSTER_ID and pass it together with other clusterProperties to segment.
  2. Use the clusterId and organizationId to calculate the anonymized user identifier for segment.
  3. Extract the "debug" feature for log every event into a separate listener extension.

I've tested this together with 889 on a cluster bot:

CONSOLE-4014.mp4

/cc @jhadvig @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig
jhadvig reviewed Apr 25, 2024
View reviewed changes
dynamic-demo-plugin/src/utils/telemetry.ts
// With 4.15+ we can use the user object directly, but on older releases (<4.15)
// we need to extract the user object from the metadata.
// All properties are defined in the UserInfo interface and marked as optional.
const uid = user?.uid || user?.metadata?.uid;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down the road we should be having helpers for getting these so we dont need to care about the path

jhadvig
jhadvig approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Apr 25, 2024

Docs Approver:
/assign @opayne1
PX Approver:
/assign @RickJWagner

@opayne1
Copy link
Contributor

opayne1 commented Apr 25, 2024

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 25, 2024
@RickJWagner
Copy link

Thank you for the nice video, it adds a lot of context for reviewers.

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 25, 2024
@RickJWagner RickJWagner removed their assignment Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6c7e5f0 and 2 for PR HEAD fa0ddfd in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD aa4dbc0 and 1 for PR HEAD fa0ddfd in total

@jerolimov
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dfe987f into openshift:master Apr 26, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.16.0-202404261114.p0.gdfe987f.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-04-29-154406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@jhadvig jhadvig

@opayne1 opayne1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jerolimov @openshift-ci-robot @jhadvig @yapei @opayne1 @RickJWagner @openshift-bot @openshift-merge-robot