Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-32697: Routes created by devfiles do not always use HTTPS #13787

Merged
merged 1 commit into from
May 6, 2024
Merged

[release-4.14] OCPBUGS-32697: Routes created by devfiles do not always use HTTPS #13787

merged 1 commit into from
May 6, 2024

Conversation

lokanandaprabhu
Copy link
Contributor

This is manual cherry pick for PR - #13771

Video:

Screen.Recording.2024-04-23.at.11.08.38.AM.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32697, which is invalid:

  • expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15.z" instead
  • expected dependent Jira Issue OCPBUGS-32391 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is manual cherry pick for PR - #13771

Video:

Screen.Recording.2024-04-23.at.11.08.38.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 23, 2024
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Apr 23, 2024
@lokanandaprabhu
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32697, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32391 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jerolimov
jerolimov approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed
/approve
/retest

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 23, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@jerolimov
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 28, 2024
@openshift-ci-robot
Copy link
Contributor

@jerolimov: This pull request references Jira Issue OCPBUGS-32697, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-32391 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32391 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 28, 2024
@lokanandaprabhu
Copy link
Contributor Author

@sanketpathak / @The-Anton ,

Need cherry-pick-approved label for this. PTAL.

@The-Anton
Copy link
Member

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2024
vikram-raj
vikram-raj reviewed May 6, 2024
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 6, 2024

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fdb388f into openshift:release-4.14 May 6, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-32697: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32697 has been moved to the MODIFIED state.

In response to this:

This is manual cherry pick for PR - #13771

Video:

Screen.Recording.2024-04-23.at.11.08.38.AM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

@lokanandaprabhu: #13787 failed to apply on top of branch "release-4.13":

Applying: Added secure route section for devfile import if tls settings is defined in devfile
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/import/GitImportForm.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/import/GitImportForm.tsx
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/import/GitImportForm.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Added secure route section for devfile import if tls settings is defined in devfile
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.14.0-202405061208.p0.gfdb388f.assembly.stream.el8 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-05-06-161147

@lokanandaprabhu lokanandaprabhu mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@jerolimov jerolimov jerolimov approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@juzhao juzhao

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet